Re: [Tarantool-patches] [PATCH luajit 2/4] Improve last commit.

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1514 bytes --]

Hi, Sergey!

thanks for the patch! LGTM

On 10.01.2025 16:07, Sergey Kaplun wrote:
> From: Mike Pall <mike>
>
> (cherry picked from commit 113a168b792cd367822ec04cdc2ef32facd28efa)
>
> The `noconflict()` function checks if there's no conflicting instruction
> between the current instruction and the given `ref` instruction. Also,
> it avoids fusing loads if there are multiple references of the given
> `ref`. The last check is performed in the presence of the `noload`
> parameter. Since the `noconflict()`, which is added in the previous
> patch, checks conflicts for the same `ref` as the call before, there is
> no need to perform these checks again, so the corresponding parameter is
> adjusted.
>
> Sergey Kaplun:
> * added the description for the problem
>
> Part of tarantool/tarantool#10709
> ---
>   src/lj_asm_x86.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lj_asm_x86.h b/src/lj_asm_x86.h
> index f47c460a..cba7ba80 100644
> --- a/src/lj_asm_x86.h
> +++ b/src/lj_asm_x86.h
> @@ -465,7 +465,7 @@ static Reg asm_fuseload(ASMState *as, IRRef ref, RegSet allow)
>         }
>       } else if (ir->o == IR_ALOAD || ir->o == IR_HLOAD || ir->o == IR_ULOAD) {
>         if (noconflict(as, ref, ir->o + IRDELTA_L2S, 0) &&
> -	  noconflict(as, ref, IR_CALLS, 0) &&  /* Don't cross table.clear. */
> +	  noconflict(as, ref, IR_CALLS, 1) &&  /* Don't cross table.clear. */
>   	  !(LJ_GC64 && irt_isaddr(ir->t))) {
>   	asm_fuseahuref(as, ir->op1, xallow);
>   	return RID_MRM;

[-- Attachment #2: Type: text/html, Size: 1994 bytes --]