Re: [Tarantool-patches] [PATCH 0/2] Add constraint names hash table to space

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Hi! Thanks for the patchset!

On 12/11/2019 15:02, Roman Khabibov wrote:
> I know, that this patchset requires more tests. I will add them in
> the next answer. For now look at the code.
> 

Please, write tests, if you have more. All the new code should be
covered. Tests are needed regardless of what I am going to comment.

Put branch and issue links here, not in the end. Otherwise they
are considered a comment in my email client, and are not added
to a response email.

> Roman Khabibov (2):
>   box: introduce constraint names hash table
>   sql: make constraint operations transactional
> 
>  src/box/alter.cc                 | 254 +++++++++++++++++++++++++++++--
>  src/box/space.c                  |  46 ++++++
>  src/box/space.h                  |  40 +++++
>  test/sql-tap/constraint.test.lua | 244 +++++++++++++++++++++++++++++
>  4 files changed, 574 insertions(+), 10 deletions(-)
>  create mode 100755 test/sql-tap/constraint.test.lua
>