From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: Alexander Turenko <alexander.turenko@tarantool.org>,
tarantool-patches@freelists.org
Subject: [tarantool-patches] [PATCH] Fix -Werror -Wimplicit-fallthrough build
Date: Mon, 3 Sep 2018 19:16:05 +0300 [thread overview]
Message-ID: <47969ef684b1bb3f4c93aa308a919f2b0758f9a6.1535989378.git.alexander.turenko@tarantool.org> (raw)
-Wimplicit-fallthrough is enabled by -Wextra on GCC 7, so it breaks our
Debug build with this version of the compiler.
Fixes #3658.
---
branch: https://github.com/tarantool/tarantool/tree/Totktonada/gh-3658-fix-gcc-7
issue: https://github.com/tarantool/tarantool/issues/3658
src/box/sql/insert.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/box/sql/insert.c b/src/box/sql/insert.c
index 550514c03..f7d489fe3 100644
--- a/src/box/sql/insert.c
+++ b/src/box/sql/insert.c
@@ -891,6 +891,7 @@ vdbe_emit_constraint_checks(struct Parse *parse_context, struct Table *tab,
switch (on_conflict_nullable) {
case ON_CONFLICT_ACTION_ABORT:
sqlite3MayAbort(parse_context);
+ FALLTHROUGH;
case ON_CONFLICT_ACTION_ROLLBACK:
case ON_CONFLICT_ACTION_FAIL:
err_msg = sqlite3MPrintf(db, "%s.%s", def->name,
--
2.17.1
next reply other threads:[~2018-09-03 16:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 16:16 Alexander Turenko [this message]
2018-09-05 10:15 ` [tarantool-patches] " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47969ef684b1bb3f4c93aa308a919f2b0758f9a6.1535989378.git.alexander.turenko@tarantool.org \
--to=alexander.turenko@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH] Fix -Werror -Wimplicit-fallthrough build' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox