From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: sergepetrenko <sergepetrenko@tarantool.org>,
Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 4/5] vclock: ignore 0th component in comparisons.
Date: Wed, 25 Dec 2019 17:00:55 +0100 [thread overview]
Message-ID: <473fde0d-7dfb-1dcd-a608-63e0ad78d20f@tarantool.org> (raw)
In-Reply-To: <42999683415fb48efba3821b59ef7e62ad00cf16.1577277455.git.sergepetrenko@tarantool.org>
Thanks for working on this!
The first 4 commits LGTM. I've force pushed a tiny
nit fix below:
diff --git a/src/box/vclock.h b/src/box/vclock.h
index 35ba6284c..5d1a50d3d 100644
--- a/src/box/vclock.h
+++ b/src/box/vclock.h
@@ -289,7 +289,6 @@ vclock_compare(const struct vclock *a, const struct vclock *b)
replica_id = bit_iterator_next(&it);
for (; replica_id < VCLOCK_MAX; replica_id = bit_iterator_next(&it)) {
-
int64_t lsn_a = vclock_get(a, replica_id);
int64_t lsn_b = vclock_get(b, replica_id);
le = le && lsn_a <= lsn_b;
next prev parent reply other threads:[~2019-12-25 16:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 12:46 [Tarantool-patches] [PATCH v2 0/5] introduce anonymous replicas sergepetrenko
2019-12-25 12:46 ` [Tarantool-patches] [PATCH v2 1/5] box: update comment describing join protocol sergepetrenko
2019-12-25 12:46 ` [Tarantool-patches] [PATCH v2 2/5] replication: do not decode replicaset uuid when processing a subscribe sergepetrenko
2019-12-25 12:47 ` [Tarantool-patches] [PATCH v2 3/5] applier: split join processing into two stages sergepetrenko
2019-12-25 12:47 ` [Tarantool-patches] [PATCH v2 4/5] vclock: ignore 0th component in comparisons sergepetrenko
2019-12-25 16:00 ` Vladislav Shpilevoy [this message]
2019-12-27 18:42 ` Vladislav Shpilevoy
2019-12-28 11:21 ` Sergey Petrenko
2019-12-25 12:47 ` [Tarantool-patches] [PATCH v2 5/5] replication: introduce anonymous replica sergepetrenko
2019-12-25 18:22 ` Vladislav Shpilevoy
2019-12-27 15:27 ` Sergey Petrenko
2019-12-27 18:42 ` Vladislav Shpilevoy
2019-12-28 11:48 ` Sergey Petrenko
2019-12-28 12:15 ` Vladislav Shpilevoy
2019-12-30 5:12 ` [Tarantool-patches] [PATCH v2 0/5] introduce anonymous replicas Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473fde0d-7dfb-1dcd-a608-63e0ad78d20f@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 4/5] vclock: ignore 0th component in comparisons.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox