From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/2] sql: get rid off sqlite3NestedParse in clean stats
Date: Mon, 9 Jul 2018 13:20:09 +0300 [thread overview]
Message-ID: <462a6bf7-d111-b297-7363-96e938c0b25c@tarantool.org> (raw)
In-Reply-To: <c1c1fef6-9b58-6440-1647-f37a83a6372f@tarantool.org>
Hello. Thanks for the fixes! I have force pushed my two-line minor
fix of a comment on the branch.
>> Also I have found that vdbe_emit_open_cursor() has the second
>> parameter named 'index_id', but in some places the function
>> takes real index_id, in other places it takes tnum, and in vdbe
>> it is interpreted as tnum. Please, fix this mess in a separate
>> commit. I think, we should always pass index_id.
> I've tried to do this and I'll append my diff to the end of this message,
> but there are some strange things..
> This should be investigated separately. I don't mind to do this, but I believe
> that this may delayed to be not a part of "remove sqlite3NestedParse function".
>
> Take a look at the end of this message.
Then fix this please on a separate branch. If it is easy, then it can be
done without an issue. If it takes more than 4 hours, then create an issue,
please.
next prev parent reply other threads:[~2018-07-09 10:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 17:17 [tarantool-patches] [PATCH v1 0/2] sql: get rid off sqlite3NestedParse Kirill Shcherbatov
2018-07-04 17:17 ` [tarantool-patches] [PATCH v1 1/2] sql: get rid off sqlite3NestedParse in clean stats Kirill Shcherbatov
2018-07-05 16:11 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-06 18:13 ` Kirill Shcherbatov
2018-07-09 10:20 ` Vladislav Shpilevoy [this message]
2018-07-04 17:17 ` [tarantool-patches] [PATCH v1 2/2] sql: remove usless sqlite3NestedParse function Kirill Shcherbatov
2018-07-05 16:11 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-06 18:13 ` Kirill Shcherbatov
2018-07-09 10:20 ` [tarantool-patches] Re: [PATCH v1 0/2] sql: get rid off sqlite3NestedParse Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=462a6bf7-d111-b297-7363-96e938c0b25c@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/2] sql: get rid off sqlite3NestedParse in clean stats' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox