From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/3] error: move errno into an error object
Date: Wed, 6 Nov 2019 17:49:01 +0300 [thread overview]
Message-ID: <45dad4ec-5449-0d76-8ffd-55f0ea15f674@tarantool.org> (raw)
In-Reply-To: <20191105181830.GL29784@atlas>
On 05/11/2019 21:18, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/11/05 17:57]:
>
> syserror is a non-obvious name, I realize you can't use errno
> since it is a macro, you could use save_errno, sys_errno,
> m_errno, anything that would make it obvious it is a saved errno
> (saved_errno?) instead.
Yes, I tried to use just 'errno', but seems like it can be a macros.
m_errno is rather C++ style. Sys_errno sounds tautological - errno
presumes 'sys'.
I choose 'saved_errno'.
Renamed on the branch.
next prev parent reply other threads:[~2019-11-06 14:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 14:59 [Tarantool-patches] [PATCH 0/3] Replication status errno Vladislav Shpilevoy
2019-11-05 14:59 ` [Tarantool-patches] [PATCH 1/3] access: fix invalid error type for not found user Vladislav Shpilevoy
2019-11-05 18:15 ` Konstantin Osipov
2019-11-06 14:48 ` Vladislav Shpilevoy
2019-11-05 14:59 ` [Tarantool-patches] [PATCH 2/3] error: move errno into an error object Vladislav Shpilevoy
2019-11-05 18:18 ` Konstantin Osipov
2019-11-06 14:49 ` Vladislav Shpilevoy [this message]
2019-11-05 14:59 ` [Tarantool-patches] [PATCH 3/3] replication: show errno in replication info Vladislav Shpilevoy
2019-11-05 18:18 ` Konstantin Osipov
2019-11-05 18:13 ` [Tarantool-patches] [PATCH 0/3] Replication status errno Konstantin Osipov
2019-11-21 17:38 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45dad4ec-5449-0d76-8ffd-55f0ea15f674@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/3] error: move errno into an error object' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox