From: Ilya Kosarev <i.kosarev@tarantool.org> To: tarantool-patches@dev.tarantool.org Cc: v.shpilevoy@tarantool.org Subject: [Tarantool-patches] [PATCH v3 2/2] memtx: allow quota overuse for truncation and deletion Date: Mon, 20 Jan 2020 21:13:20 +0300 [thread overview] Message-ID: <45d9f491f91d93c8835ca725c234f7113c0d2aa8.1579541242.git.i.kosarev@tarantool.org> (raw) In-Reply-To: <cover.1579541242.git.i.kosarev@tarantool.org> In-Reply-To: <cover.1579541242.git.i.kosarev@tarantool.org> Trying to perform space:truncate() and space:delete() while reaching memtx_memory limit we could experience slab allocator failure. This behavior seems to be quite surprising for users. Now we are allowing to overuse memtx quota if needed for truncation or deletion, using flag in struct quota. After performing truncation or deletion we reset the flag so that quota can be overused any more. Closes #3807 --- src/box/box.cc | 5 +++++ src/box/memtx_engine.c | 9 +++++++++ src/box/memtx_engine.h | 3 +++ src/box/memtx_space.c | 13 +++++++++---- src/lib/small | 2 +- 5 files changed, 27 insertions(+), 5 deletions(-) diff --git a/src/box/box.cc b/src/box/box.cc index 1b2b27d61..678c9ffe3 100644 --- a/src/box/box.cc +++ b/src/box/box.cc @@ -1321,9 +1321,14 @@ space_truncate(struct space *space) ops_buf_end = mp_encode_uint(ops_buf_end, 1); assert(ops_buf_end < buf + buf_size); + struct space *truncate_space = space_cache_find_xc(BOX_TRUNCATE_ID); + memtx_engine_set_quota_strictness(truncate_space->engine, false); + if (box_upsert(BOX_TRUNCATE_ID, 0, tuple_buf, tuple_buf_end, ops_buf, ops_buf_end, 0, NULL) != 0) diag_raise(); + + memtx_engine_set_quota_strictness(truncate_space->engine, true); } int diff --git a/src/box/memtx_engine.c b/src/box/memtx_engine.c index 4da80824a..c19205d34 100644 --- a/src/box/memtx_engine.c +++ b/src/box/memtx_engine.c @@ -1090,6 +1090,15 @@ memtx_engine_set_memory(struct memtx_engine *memtx, size_t size) return 0; } +void +memtx_engine_set_quota_strictness(struct engine *engine, bool strict) +{ + if (strncmp(engine->name, "memtx", 5) != 0) + return; + struct memtx_engine *memtx = (struct memtx_engine *)engine; + quota_set_strictness(&memtx->quota, strict); +} + void memtx_engine_set_max_tuple_size(struct memtx_engine *memtx, size_t max_size) { diff --git a/src/box/memtx_engine.h b/src/box/memtx_engine.h index f562c66df..0793fc2ab 100644 --- a/src/box/memtx_engine.h +++ b/src/box/memtx_engine.h @@ -213,6 +213,9 @@ memtx_engine_set_snap_io_rate_limit(struct memtx_engine *memtx, double limit); int memtx_engine_set_memory(struct memtx_engine *memtx, size_t size); +void +memtx_engine_set_quota_strictness(struct engine *engine, bool strict); + void memtx_engine_set_max_tuple_size(struct memtx_engine *memtx, size_t max_size); diff --git a/src/box/memtx_space.c b/src/box/memtx_space.c index 6ef84e045..20ce2f974 100644 --- a/src/box/memtx_space.c +++ b/src/box/memtx_space.c @@ -354,10 +354,15 @@ memtx_space_execute_delete(struct space *space, struct txn *txn, struct tuple *old_tuple; if (index_get(pk, key, part_count, &old_tuple) != 0) return -1; - if (old_tuple != NULL && - memtx_space->replace(space, old_tuple, NULL, - DUP_REPLACE_OR_INSERT, &stmt->old_tuple) != 0) - return -1; + if (old_tuple != NULL) { + memtx_engine_set_quota_strictness(space->engine, false); + int rc = memtx_space->replace(space, old_tuple, NULL, + DUP_REPLACE_OR_INSERT, + &stmt->old_tuple); + memtx_engine_set_quota_strictness(space->engine, true); + if (rc != 0) + return -1; + } stmt->engine_savepoint = stmt; *result = stmt->old_tuple; return 0; diff --git a/src/lib/small b/src/lib/small index 50cb78743..bdcd569f9 160000 --- a/src/lib/small +++ b/src/lib/small @@ -1 +1 @@ -Subproject commit 50cb7874380b286f3b34c82299cf5eb88b0d0059 +Subproject commit bdcd569f9ed753efb805f708089ca86e2520a44f -- 2.17.1
next prev parent reply other threads:[~2020-01-20 18:13 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-20 18:13 [Tarantool-patches] [PATCH v3 0/2] Safe " Ilya Kosarev 2020-01-20 18:13 ` [Tarantool-patches] [PATCH v3 1/2] b-tree: return NULL on matras_alloc fail Ilya Kosarev 2020-01-21 10:32 ` Nikita Pettik 2020-01-31 8:18 ` Konstantin Osipov 2020-02-04 17:13 ` Nikita Pettik 2020-02-04 17:25 ` Konstantin Osipov 2020-02-04 18:08 ` Nikita Pettik 2020-02-04 18:25 ` Konstantin Osipov 2020-01-21 20:55 ` Vladislav Shpilevoy 2020-01-20 18:13 ` Ilya Kosarev [this message] 2020-01-21 11:42 ` [Tarantool-patches] [PATCH v3 2/2] memtx: allow quota overuse for truncation and deletion Nikita Pettik 2020-01-21 20:59 ` Vladislav Shpilevoy 2020-02-14 19:57 ` Ilya Kosarev 2020-01-31 8:21 ` Konstantin Osipov 2020-02-04 18:56 ` Ilya Kosarev 2020-02-04 20:06 ` Konstantin Osipov 2020-02-05 19:11 ` Ilya Kosarev 2020-02-05 19:17 ` Konstantin Osipov 2020-02-06 10:50 ` Ilya Kosarev 2020-02-06 14:29 ` Konstantin Osipov 2020-02-06 16:14 ` Ilya Kosarev 2020-02-06 16:26 ` Konstantin Osipov 2020-02-10 8:24 ` Ilya Kosarev 2020-02-10 9:49 ` Konstantin Osipov 2020-02-10 10:43 ` Ilya Kosarev 2020-02-10 10:50 ` Konstantin Osipov 2020-02-14 19:55 ` Ilya Kosarev
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=45d9f491f91d93c8835ca725c234f7113c0d2aa8.1579541242.git.i.kosarev@tarantool.org \ --to=i.kosarev@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v3 2/2] memtx: allow quota overuse for truncation and deletion' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox