From: Oleg Babin <olegrok@tarantool.org>
To: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] fiber: set diag error on madvise, mprotect fails
Date: Sat, 11 Jan 2020 10:03:33 +0300 [thread overview]
Message-ID: <43fa7862-777b-1717-71e0-ccb8865d23e5@tarantool.org> (raw)
In-Reply-To: <20200110142749.11577-1-gorcunov@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 864 bytes --]
Hello, thanks for your patch!
Our documentation doesn't contain any mentions that fiber.create can fail.
Could you please file an issue (or may be doc bot request) with
description in what cases user
can expect that fiber.create will fail. Usually users don't use pcall
for fiber.create and this fact can
be quite unexpected for them.
On 10/01/2020 17:27, Cyrill Gorcunov wrote:
> Currently we use say_x to log if error happened.
> Strictly speaking when madvise is used to relax
> pressue on mm subsystem since we started to use
> bigger stacks (due to libreadline increased memory
> usage).
>
> Same time mprotect usage is more sensitive -- we
> setup guard pages with its help and when failing
> it is definitely an error which we should not only
> mention in logger but provide a caller diag error.
> Here is an example from memcached
>
--
Oleg Babin
[-- Attachment #2: Type: text/html, Size: 3092 bytes --]
next prev parent reply other threads:[~2020-01-11 7:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 14:27 Cyrill Gorcunov
2020-01-11 7:03 ` Oleg Babin [this message]
2020-01-11 7:38 ` Cyrill Gorcunov
2020-01-12 9:27 ` Cyrill Gorcunov
2020-01-15 13:35 ` Alexander Turenko
2020-01-15 13:39 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43fa7862-777b-1717-71e0-ccb8865d23e5@tarantool.org \
--to=olegrok@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] fiber: set diag error on madvise, mprotect fails' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox