Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alex Khatskevich <avkhatskevich@tarantool.org>
To: "n.pettik" <korablev@tarantool.org>, tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] sql: export `sql_current_time` && enable tests
Date: Wed, 27 Jun 2018 23:06:02 +0300	[thread overview]
Message-ID: <425ebcd7-9ec3-adaf-fc50-69a2a9c2b107@tarantool.org> (raw)
In-Reply-To: <4AD7FCD7-67EB-4B16-BC6A-641FAE19E17E@tarantool.org>



On 26.06.2018 19:21, n.pettik wrote:
>> -- Test cases table-14.*
>> --
>> @@ -970,26 +944,6 @@ end
>> -- But DROP TABLE is still prohibited because we do not want to
>> -- delete a table out from under a running query.
>> --
>> --- db eval {
>> ---   pragma vdbe_trace = 0;
>> --- }
>> --- Try to create a table from within a callback:
>> --- ["unset","-nocomplain","result"]
>> -test:do_test(
>> -    "table-14.1",
>> -    function()
>> -        local rc = pcall(function()
>> -            test:execsql("SELECT * FROM tablet8 LIMIT 1")
>> -            test:execsql("CREATE TABLE t9(a primary key, b, c)")
>> -            end)
>> -        rc = rc == true and 0 or 1
>> -        return { rc }
>> -    end, {
>> -        -- <table-14.1>
>> -        0
>> -        -- </table-14.1>
>> -    })
>> -
> Idk why did you delete this test within current patch?
>
> The rest seems to be OK.
>
As far as I remember, test was testing ddl inside of a running 
transaction in SQLite with the help of
special TCL api.
However, those lines do not test anything at all and there is a 14.2 
test which does test this case.

1. I have added this text to the commit message.
2. I have rebased this branch on top of 2.0

  reply	other threads:[~2018-06-27 20:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16 13:33 [tarantool-patches] " AKhatskevich
2018-06-26 16:21 ` [tarantool-patches] " n.pettik
2018-06-27 20:06   ` Alex Khatskevich [this message]
2018-06-27 21:53     ` n.pettik
2018-06-29 13:43       ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=425ebcd7-9ec3-adaf-fc50-69a2a9c2b107@tarantool.org \
    --to=avkhatskevich@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH] sql: export `sql_current_time` && enable tests' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox