From: Sergey Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org, gorcunov@gmail.com
Subject: Re: [Tarantool-patches] [PATCH 1/2] replication: introduce ballot.can_be_leader
Date: Mon, 19 Jul 2021 11:11:21 +0200 [thread overview]
Message-ID: <41d22ee6-c2b8-1fec-f6f3-7e7ae92fcd81@tarantool.org> (raw)
In-Reply-To: <a884387f-93eb-fc57-047a-a2fca618b2b5@tarantool.org>
18.07.2021 19:00, Vladislav Shpilevoy пишет:
> Hi! Thanks for the review!
>
>> Hi and thanks for the patch!
>>
>> It's all good except the field name. It's rather long IMO, and may be
>> confused with bootsrap leader, which we try to find using ballots.
>>
>> Wouldn't "can be candidate", or "is_election_candidate" be better?
> `is_election_candidate` is even longer. I thought about `can_be_candidate`
> firstly, but then I realized that it is the same as `can_be_leader`, because
> the purpose of a candidate is to become a leader anyway. And we are looking
> for a leader, not a candidate. The latter is just an intermediate state.
>
> I shortened the name to `can_lead`. Ok?
Sounds good, thanks!
>
> As for inability to boot a cluster we might in the future add a flag `can_boot`
> if necessary. See new patch in v2.
next prev parent reply other threads:[~2021-07-19 9:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 23:49 [Tarantool-patches] [PATCH 0/2] Bootstrap voter Vladislav Shpilevoy via Tarantool-patches
2021-07-15 23:49 ` [Tarantool-patches] [PATCH 1/2] replication: introduce ballot.can_be_leader Vladislav Shpilevoy via Tarantool-patches
2021-07-16 10:59 ` Serge Petrenko via Tarantool-patches
2021-07-18 17:00 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-19 9:11 ` Sergey Petrenko via Tarantool-patches [this message]
2021-07-16 14:29 ` Konstantin Osipov via Tarantool-patches
2021-07-18 17:00 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-19 9:12 ` Konstantin Osipov via Tarantool-patches
2021-07-19 22:06 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-20 8:49 ` Konstantin Osipov via Tarantool-patches
2021-07-20 20:02 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-20 20:18 ` Konstantin Osipov via Tarantool-patches
2021-07-20 21:16 ` Cyrill Gorcunov via Tarantool-patches
2021-07-20 23:20 ` Konstantin Osipov via Tarantool-patches
2021-07-21 18:51 ` Cyrill Gorcunov via Tarantool-patches
2021-07-21 21:43 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-15 23:49 ` [Tarantool-patches] [PATCH 2/2] election: during bootstrap prefer candidates Vladislav Shpilevoy via Tarantool-patches
2021-07-16 11:30 ` Serge Petrenko via Tarantool-patches
2021-07-18 17:00 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-16 14:27 ` [Tarantool-patches] [PATCH 0/2] Bootstrap voter Konstantin Osipov via Tarantool-patches
2021-07-18 17:00 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-19 9:13 ` Konstantin Osipov via Tarantool-patches
2021-07-19 22:04 ` Vladislav Shpilevoy via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41d22ee6-c2b8-1fec-f6f3-7e7ae92fcd81@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/2] replication: introduce ballot.can_be_leader' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox