From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 178BD6EC55; Mon, 19 Jul 2021 12:11:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 178BD6EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1626685885; bh=RmSfRxtMTxVD3R+Dj+1b1Sulq2W/lYH/psvxzt4J+Ug=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=g0NoQnMN3ReAImYT6xNZLOUIs8GgXi8+ywd5wv9845E3IQGJ60VlLuQhRA9HTwa0K cVu5k4TM12ukAxd7uyHKQcMT8QtLeeZIz0j3mPlbH2bkv/XJsHlrE0JPX9hb5sQpJR 8wGT6Z1IMokj/AgMiGR/6kMsA6iV8pe7bdKrmrvE= Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7F2A36EC55 for ; Mon, 19 Jul 2021 12:11:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7F2A36EC55 Received: by smtp59.i.mail.ru with esmtpa (envelope-from ) id 1m5PJ4-0002Mp-PD; Mon, 19 Jul 2021 12:11:23 +0300 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org, gorcunov@gmail.com References: <0c92a88ff1d392f8b03de59be8cb19a162bf78f8.1626392372.git.v.shpilevoy@tarantool.org> <37473da3-8525-16cb-f096-49c8c90e00d5@tarantool.org> Message-ID: <41d22ee6-c2b8-1fec-f6f3-7e7ae92fcd81@tarantool.org> Date: Mon, 19 Jul 2021 11:11:21 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C30288BCF456A452EC92BAB6D044D5CCDE182A05F5380850409D7B87AA801A17C12BCB05D646C93B64E3C74CF3076669AF741BCD6D7C02B544 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7461BBD5973015A08EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063727599E9BE65898D58638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D850EBD9521173E77587B32A26C03890FD117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC292D688DDAD4E7BC389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8FA486DC37A503D0BF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C24F796C710B8583C040F9FF01DFDA4A84AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C397DCCBFEAAA0BC6A76E601842F6C81A1F004C906525384307823802FF610243DF43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7CDDB9BF3B882869D543847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A538A940F93F0D416363518FCAFA2A89770A7AA29F39CB74EAD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3419891600CCEF460772A326C731BF8B6AC442AE29CAB25050FA2701BD1DA4F799075E72829B6390251D7E09C32AA3244CAAAB0074F43026573CEC8F911003C669725D5B54B2FE4575FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj+8+KVR9NZrF0DS8xzRjHCQ== X-Mailru-Sender: 9482C2B233321BD2A52C8BE47D7A9D6590130CE3A1EE420DBBDD104054B82BE811A5FC24377CCE666BB2E709EA627F343C7DDD459B58856F0E45BC603594F5A135B915D4279FF0579437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/2] replication: introduce ballot.can_be_leader X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Petrenko via Tarantool-patches Reply-To: Sergey Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 18.07.2021 19:00, Vladislav Shpilevoy пишет: > Hi! Thanks for the review! > >> Hi and thanks for the patch! >> >> It's all good except the field name. It's rather long IMO, and may be >> confused with bootsrap leader, which we try to find using ballots. >> >> Wouldn't "can be candidate", or "is_election_candidate" be better? > `is_election_candidate` is even longer. I thought about `can_be_candidate` > firstly, but then I realized that it is the same as `can_be_leader`, because > the purpose of a candidate is to become a leader anyway. And we are looking > for a leader, not a candidate. The latter is just an intermediate state. > > I shortened the name to `can_lead`. Ok? Sounds good, thanks! > > As for inability to boot a cluster we might in the future add a flag `can_boot` > if necessary. See new patch in v2.