Re: [Tarantool-patches] [PATCH] replication: remove unnecessary errors on replicating from an anonymous instance

[Serge Petrenko <sergepetrenko@tarantool.org>]

07.05.2020 00:51, Vladislav Shpilevoy пишет:
> Hi! Thanks for the fixes!


Thanks for the review!

> See 2 keyboard-related nits below. Everything else LGTM.
>
>> diff --git a/test/replication/anon.result b/test/replication/anon.result
>> index 997112c84..8782212ca 100644
>> --- a/test/replication/anon.result
>> +++ b/test/replication/anon.result
>> @@ -366,9 +367,9 @@ test_run:cmd('switch replica_anon2')
>>    | ---
>>    | - true
>>    | ...
>> -box.space.test:select{}
>> +test_run:wait_cond(function() return box.space.test:get{1} ~= nil  end, 10)
> 1. :) Double whitespace after '~= nil'.

Thanks =)

Fixed.

>>    | ---
>> - | - - [1]
>> + | - true
>>    | ...
>> @@ -429,36 +430,10 @@ test_run:cmd('set variable repl_source to "replica_anon1.listen"')
>>   box.cfg{replication=repl_source}
>>    | ---
>>    | ...
>> -
>> -test_run:cmd('switch default')
>> - | ---
>> - | - true
>> - | ...
>> -box.space.test:insert{2}
>> - | ---
>> - | - [2]
>> - | ...
>> -
>> -test_run:cmd('switch replica_anon1')
>> - | ---
>> - | - true
>> - | ...
>> --- Check that the new replica follows an anonymous one.
>> -test_run:wait_downstream(2, {status='follow'})
>> +test_run:wait_log('replica', 'ER_UNSUPPORTED: Anonymous replica does not support non.anonymous followers.', nil, 10)
> 2. Perhaps 'non-anonymous' instead of 'non.anonymous'?

Dot  matches anything, and I couldn't find a way to escape '-', it must 
be a special symbol of sorts.
So let it be 'non.anonymous'.

-- 
Serge Petrenko