From: Leonid Vasiliev <lvasiliev@tarantool.org>
To: Sergey Nikiforov <void@tarantool.org>,
tarantool-patches@dev.tarantool.org
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
Sergey Nikiforov <void234@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v5 0/2] base64: Fix decoder, improve its performance
Date: Fri, 25 Dec 2020 16:08:54 +0300 [thread overview]
Message-ID: <41a964bf-b635-6ea6-858f-9a634ee2210d@tarantool.org> (raw)
In-Reply-To: <cover.1608892639.git.void234@gmail.com>
Hi!
The patchset LGTM.
I think it can be sent to A. Turenko to recive the second LGTM.
Add links to issue and branch.
On 25.12.2020 13:41, Sergey Nikiforov wrote:
> From: Sergey Nikiforov <void234@gmail.com>
>
> First patch fixes #3069 and adds test for zero-sized output buffer,
> second one improves base64 decoder performance
>
> Sergey Nikiforov (2):
> base64: fix decoder output buffer overrun (reads)
> base64: improve decoder performance
>
> test/unit/base64.c | 13 +++++++++-
> test/unit/base64.result | 3 ++-
> third_party/base64.c | 57 +++++++++++++++++++++++++++++------------
> 3 files changed, 54 insertions(+), 19 deletions(-)
>
next prev parent reply other threads:[~2020-12-25 13:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-25 10:41 Sergey Nikiforov
2020-12-25 10:41 ` [Tarantool-patches] [PATCH v5 1/2] base64: fix decoder output buffer overrun (reads) Sergey Nikiforov
2020-12-25 13:00 ` Leonid Vasiliev
2020-12-25 10:41 ` [Tarantool-patches] [PATCH v5 2/2] base64: improve decoder performance Sergey Nikiforov
2020-12-25 13:01 ` Leonid Vasiliev
2020-12-25 13:08 ` Leonid Vasiliev [this message]
2020-12-25 14:09 [Tarantool-patches] [PATCH v5 0/2] base64: Fix decoder, improve its performance Sergey Nikiforov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41a964bf-b635-6ea6-858f-9a634ee2210d@tarantool.org \
--to=lvasiliev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--cc=void234@gmail.com \
--cc=void@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v5 0/2] base64: Fix decoder, improve its performance' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox