From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/3] box: introduce 'virtual' engine
Date: Sat, 21 Dec 2019 18:59:17 +0100 [thread overview]
Message-ID: <416ece86-4230-4639-c3d6-6430b8ece4c8@tarantool.org> (raw)
In-Reply-To: <7439b83392c9979f900966993ddaa2425a10b667.1576743850.git.imeevma@gmail.com>
Hi! Thanks for the patch!
I've pushed my review fixes on top of this commit. See it below
and on the branch. If you agree, then squash. Otherwise lets
discuss.
==================================================================
commit b3d8950d07a620ecbb19318495d33a59af5733b5
Author: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Date: Sat Dec 21 18:02:43 2019 +0100
Review fixes 1/3
diff --git a/src/box/virtual_engine.c b/src/box/virtual_engine.c
index 45993b91f..9a59a3f6a 100644
--- a/src/box/virtual_engine.c
+++ b/src/box/virtual_engine.c
@@ -30,7 +30,6 @@
*/
#include "virtual_engine.h"
#include "schema.h"
-#include "tuple.h"
static void
virtual_engine_shutdown(struct engine *engine)
diff --git a/src/box/virtual_engine.h b/src/box/virtual_engine.h
index 80ada450d..9cb5f520f 100644
--- a/src/box/virtual_engine.h
+++ b/src/box/virtual_engine.h
@@ -29,8 +29,6 @@
* THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
-#include <stddef.h>
-
#if defined(__cplusplus)
extern "C" {
#endif /* defined(__cplusplus) */
next prev parent reply other threads:[~2019-12-21 17:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 8:32 [Tarantool-patches] [PATCH 0/3] Introduce _session_setting system view imeevma
2019-12-19 8:32 ` [Tarantool-patches] [PATCH 1/3] box: introduce 'virtual' engine imeevma
2019-12-21 17:59 ` Vladislav Shpilevoy [this message]
2019-12-26 17:59 ` Mergen Imeev
2019-12-26 4:45 ` Konstantin Osipov
2019-12-27 13:45 ` Vladislav Shpilevoy
2019-12-19 8:32 ` [Tarantool-patches] [PATCH 2/3] box: introduce _session_settings system space imeevma
2019-12-21 17:59 ` Vladislav Shpilevoy
2019-12-26 18:01 ` Mergen Imeev
2019-12-19 8:33 ` [Tarantool-patches] [PATCH 3/3] box: add SQL settings to _session_settings imeevma
2019-12-21 17:59 ` Vladislav Shpilevoy
2019-12-26 18:07 ` Mergen Imeev
2019-12-27 13:45 ` [Tarantool-patches] [PATCH 0/3] Introduce _session_setting system view Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416ece86-4230-4639-c3d6-6430b8ece4c8@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/3] box: introduce '\''virtual'\'' engine' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox