From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH 1/3] iproto: rename iproto_bind_msg to iproto_cfg_msg
Date: Mon, 23 Apr 2018 20:00:16 +0300 [thread overview]
Message-ID: <4161e989-9462-ec56-742a-3483a0ce0323@tarantool.org> (raw)
In-Reply-To: <20180423112202.jrqfczbsvfadw4ku@esperanza>
Hello. Thanks for review!
On 23/04/2018 14:22, Vladimir Davydov wrote:
> On Sat, Apr 21, 2018 at 01:52:09AM +0300, Vladislav Shpilevoy wrote:
>> IProto_bind_msg is used by TX thread to udpate bind address in
>> IProto thread with no explicit locking anything.
>>
>> In #3320 new IProto dynamic configuration parameter appears -
>> 'iproto_msg_max' which regulates how many IProto requests can be
>> in fly.
>>
>> The idea is to reuse iproto_bind_msg for this.
>>
>> Part of #3320
>> ---
>> src/box/iproto.cc | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> I don't see any point in this patch. Patch 3 overwrites half of it
> anyway so it doesn't really facilitate review. Please squash it.
>
Done.
next prev parent reply other threads:[~2018-04-23 17:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 22:52 [PATCH 0/3] iproto: allow to configure IPROTO_MSG_MAX Vladislav Shpilevoy
[not found] ` <cover.1524264646.git.v.shpilevoy@tarantool.org>
2018-04-20 22:52 ` [PATCH 1/3] iproto: rename iproto_bind_msg to iproto_cfg_msg Vladislav Shpilevoy
2018-04-23 11:22 ` Vladimir Davydov
2018-04-23 17:00 ` Vladislav Shpilevoy [this message]
2018-04-20 22:52 ` [PATCH 2/3] iproto: fix error with input discarding Vladislav Shpilevoy
2018-04-23 11:20 ` Vladimir Davydov
2018-04-20 22:52 ` [PATCH 3/3] iproto: allow to configure IPROTO_MSG_MAX Vladislav Shpilevoy
2018-04-23 11:34 ` Vladimir Davydov
2018-04-23 17:00 ` [tarantool-patches] " Vladislav Shpilevoy
2018-04-24 8:04 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4161e989-9462-ec56-742a-3483a0ce0323@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] Re: [PATCH 1/3] iproto: rename iproto_bind_msg to iproto_cfg_msg' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox