From: Serge Petrenko <sergepetrenko@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>,
Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 0/2] fix flaky replication/election_qsync_stress.test.lua test
Date: Tue, 10 Nov 2020 11:46:43 +0300 [thread overview]
Message-ID: <415f4700-0d1c-a92c-e615-eb993317ffb8@tarantool.org> (raw)
In-Reply-To: <cover.1604586681.git.avtikhon@tarantool.org>
05.11.2020 17:33, Alexander V. Tikhonov пишет:
> Created 2 commits:
>
> 1. test: fix flaky election_qsync_stress with KILL
>
> Found that replication/election_qsync_stress.test.lua test may fail on
> restating instances. It occures on heavy loaded hosts when its local
> call to stop instance using SIGTERM fails to stop it. Decided to use
> SIGKILL in local stop call options to be sure that the instance will
> be stopped.
>
> 2. test: filter output message for test
>
> Added test-run filter for replication/election_qsync_stress.test.lua
> test on error message:
>
> 'error: Found uncommitted sync transactions from other instance with id [0-9]+'
>
> to avoid of printing changing data in results file to be able to use
> its checksums in fragile list of test-run to rerun it as flaky issue.
>
> Alexander V. Tikhonov (2):
> test: filter output message for test
> test: fix flaky election_qsync_stress with KILL
>
> test/replication/election_qsync_stress.result | 8 +++++++-
> test/replication/election_qsync_stress.test.lua | 5 ++++-
> test/replication/suite.ini | 2 +-
> 3 files changed, 12 insertions(+), 3 deletions(-)
>
Hi! Thanks for the patchset!
Both patches LGTM.
--
Serge Petrenko
prev parent reply other threads:[~2020-11-10 8:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 14:33 Alexander V. Tikhonov
2020-11-05 14:34 ` [Tarantool-patches] [PATCH v1 1/2] test: filter output message for test Alexander V. Tikhonov
2020-11-05 14:34 ` [Tarantool-patches] [PATCH v1 2/2] test: fix flaky election_qsync_stress with KILL Alexander V. Tikhonov
2020-11-10 8:46 ` Serge Petrenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=415f4700-0d1c-a92c-e615-eb993317ffb8@tarantool.org \
--to=sergepetrenko@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 0/2] fix flaky replication/election_qsync_stress.test.lua test' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox