From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id DA85D469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 10 Nov 2020 11:46:44 +0300 (MSK)
References: <cover.1604586681.git.avtikhon@tarantool.org>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <415f4700-0d1c-a92c-e615-eb993317ffb8@tarantool.org>
Date: Tue, 10 Nov 2020 11:46:43 +0300
MIME-Version: 1.0
In-Reply-To: <cover.1604586681.git.avtikhon@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [Tarantool-patches] [PATCH v1 0/2] fix flaky
 replication/election_qsync_stress.test.lua test
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>, Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org


05.11.2020 17:33, Alexander V. Tikhonov пишет:
> Created 2 commits:
>
> 1. test: fix flaky election_qsync_stress with KILL
>      
>    Found that replication/election_qsync_stress.test.lua test may fail on
>    restating instances. It occures on heavy loaded hosts when its local
>    call to stop instance using SIGTERM fails to stop it. Decided to use
>    SIGKILL in local stop call options to be sure that the instance will
>    be stopped.
>
> 2. test: filter output message for test
>      
>    Added test-run filter for replication/election_qsync_stress.test.lua
>    test on error message:
>      
>      'error: Found uncommitted sync transactions from other instance with id [0-9]+'
>      
>    to avoid of printing changing data in results file to be able to use
>    its checksums in fragile list of test-run to rerun it as flaky issue.
>
> Alexander V. Tikhonov (2):
>    test: filter output message for test
>    test: fix flaky election_qsync_stress with KILL
>
>   test/replication/election_qsync_stress.result   | 8 +++++++-
>   test/replication/election_qsync_stress.test.lua | 5 ++++-
>   test/replication/suite.ini                      | 2 +-
>   3 files changed, 12 insertions(+), 3 deletions(-)
>

Hi! Thanks for the patchset!

Both patches LGTM.

-- 
Serge Petrenko