From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: Maxim Kokryashkin <max.kokryashkin@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v9 1/2] tools: add cli flag to run profile dump parsers
Date: Thu, 14 Sep 2023 12:22:15 +0300 [thread overview]
Message-ID: <410e5a92-cb69-7916-baaf-9a24aa0f998c@tarantool.org> (raw)
In-Reply-To: <1694549020.38036023@f474.i.mail.ru>
Hi, Max
Thanks for the fixes!
Two new comments:
$ ./build/src/luajit -ts sysprof.bin
./build/src/luajit: ./tools/utils/symtab.lua:107: attempt to concatenate
local 'magic' (a nil value)
Please fix.
$ ./build/src/luajit -ts mee
./build/src/luajit: ./tools/utils/bufread.lua:122: fopen, errno: 2
Seems the case is not handled in your code, let's fix it.
On 9/12/23 23:03, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the review!
> Fixed all of your comments, except for the one about
> `luacheckrc` and _TARANTOOL. I believe, it should be
> done in a separate patch.
>
<snipped>
next prev parent reply other threads:[~2023-09-14 9:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 11:35 [Tarantool-patches] [PATCH luajit v9 0/2] introduce cli for tools Maxim Kokryashkin via Tarantool-patches
2023-08-31 11:35 ` [Tarantool-patches] [PATCH luajit v9 1/2] tools: add cli flag to run profile dump parsers Maxim Kokryashkin via Tarantool-patches
2023-09-03 9:50 ` Sergey Kaplun via Tarantool-patches
2023-09-04 9:30 ` Maxim Kokryashkin via Tarantool-patches
2023-09-07 9:41 ` Sergey Bronnikov via Tarantool-patches
2023-09-12 20:03 ` Maxim Kokryashkin via Tarantool-patches
2023-09-14 9:22 ` Sergey Bronnikov via Tarantool-patches [this message]
2023-09-18 8:51 ` Maxim Kokryashkin via Tarantool-patches
2023-10-04 8:58 ` Sergey Bronnikov via Tarantool-patches
2023-10-04 11:49 ` Maxim Kokryashkin via Tarantool-patches
2023-10-06 8:26 ` Sergey Bronnikov via Tarantool-patches
2023-11-23 6:33 ` Igor Munkin via Tarantool-patches
2023-08-31 11:35 ` [Tarantool-patches] [PATCH luajit v9 2/2] test: don't skip tool CLI flag for tarantool Maxim Kokryashkin via Tarantool-patches
2023-09-03 9:54 ` Sergey Kaplun via Tarantool-patches
2023-09-07 9:42 ` Sergey Bronnikov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=410e5a92-cb69-7916-baaf-9a24aa0f998c@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=sergeyb@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit v9 1/2] tools: add cli flag to run profile dump parsers' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox