From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: "N. Tatunov" <hollow653@gmail.com>
Subject: [tarantool-patches] Re: [PATCH] sql: Remove 'BEGIN TRANSACTION'
Date: Thu, 19 Jul 2018 17:03:35 +0300 [thread overview]
Message-ID: <40A96246-8FFD-4E6F-9FEC-5309A19D9DB8@tarantool.org> (raw)
In-Reply-To: <CAEi+_arorVXcHRuD9TzumEG_scx2gVKXv9e2EEn3H-J15qKROA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 872 bytes --]
>> diff --git a/extra/lempar.c b/extra/lempar.c
>> index 00fd79c..d043e39 100644
>> --- a/extra/lempar.c
>> +++ b/extra/lempar.c
>> @@ -336,8 +336,8 @@ void *ParseAlloc(void *(*mallocProc)(YYMALLOCARGTYPE)){
>> if( pParser ){
>> #ifdef YYTRACKMAXSTACKDEPTH
>> pParser->yyhwm = 0;
>> - pParser->is_fallback_failed = false;
>> #endif
>> + pParser->is_fallback_failed = false;
>
> Could you please explain this code movement?
> To be more accurate it's just variable initialization that was in wrong place.
> Moreover in most cases (almost always) after allocating memory for this
> variable there was non-zero value ('true', basically), that was causing
> "keyword 'BEGIN' is reserved" error message if we use "BEGIN" instead
> of "START TRANSACTION", after the patch changes are applied.
Ok, thx for explanation. Now patch LGTM.
[-- Attachment #2: Type: text/html, Size: 2559 bytes --]
next prev parent reply other threads:[~2018-07-19 14:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 10:42 [tarantool-patches] " N.Tatunov
2018-07-05 11:48 ` [tarantool-patches] " Nikita Tatunov
2018-07-09 15:35 ` Alexander Turenko
2018-07-13 2:15 ` n.pettik
2018-07-16 12:22 ` Nikita Tatunov
2018-07-19 0:24 ` n.pettik
2018-07-19 11:48 ` Nikita Tatunov
2018-07-19 14:03 ` n.pettik [this message]
2018-07-19 15:44 ` Vladislav Shpilevoy
2018-07-19 18:08 ` Nikita Tatunov
2018-07-19 18:13 ` Vladislav Shpilevoy
2018-07-20 13:24 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40A96246-8FFD-4E6F-9FEC-5309A19D9DB8@tarantool.org \
--to=korablev@tarantool.org \
--cc=hollow653@gmail.com \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: Remove '\''BEGIN TRANSACTION'\''' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox