From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 5/7] sql: refactor sql_trigger_step_allocate to set diag
Date: Thu, 7 Mar 2019 20:34:29 +0300 [thread overview]
Message-ID: <403432db-e4b7-fc6f-73bb-13a98ec2959f@tarantool.org> (raw)
In-Reply-To: <607ffbbc4fcdca43ccfc5e6dabaed5ca3bc7719f.1551265819.git.kshcherbatov@tarantool.org>
On 27/02/2019 14:13, Kirill Shcherbatov wrote:
> Refactored sql_trigger_step_allocate routine to use diag_set in
> case of memory allocation error. Also performed some additional
> name refactoring in adjacent places.
> This change is necessary because the sql_trigger_step_allocate
> body has a sqlNameFromToken call that will be changed in
> subsequent patches.
But you have changed it in the previous one ... . And here a
function with such name already does not exist.
The same about the next commit.
>
> Needed for #3931
> ---
next prev parent reply other threads:[~2019-03-07 17:34 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 11:13 [tarantool-patches] [PATCH v2 0/7] sql: store regular identifiers in case-normal form Kirill Shcherbatov
2019-02-27 11:13 ` [tarantool-patches] [PATCH v2 1/7] sql: refactor sql_alloc_src_list to set diag Kirill Shcherbatov
2019-03-07 17:34 ` [tarantool-patches] " Vladislav Shpilevoy
2019-03-11 15:04 ` Kirill Shcherbatov
2019-02-27 11:13 ` [tarantool-patches] [PATCH v2 2/7] sql: rework sql_src_list_enlarge " Kirill Shcherbatov
2019-03-07 17:34 ` [tarantool-patches] " Vladislav Shpilevoy
2019-03-11 15:04 ` Kirill Shcherbatov
2019-02-27 11:13 ` [tarantool-patches] [PATCH v2 3/7] sql: refactor sql_src_list_append " Kirill Shcherbatov
2019-03-07 17:34 ` [tarantool-patches] " Vladislav Shpilevoy
2019-03-11 15:04 ` Kirill Shcherbatov
2019-03-18 19:33 ` Vladislav Shpilevoy
2019-03-20 11:02 ` Kirill Shcherbatov
2019-03-26 17:08 ` Vladislav Shpilevoy
2019-03-26 18:07 ` Vladislav Shpilevoy
2019-02-27 11:13 ` [tarantool-patches] [PATCH v2 4/7] sql: refactor sql_name_from_token " Kirill Shcherbatov
2019-03-07 17:34 ` [tarantool-patches] " Vladislav Shpilevoy
2019-03-11 15:04 ` Kirill Shcherbatov
2019-03-18 19:33 ` Vladislav Shpilevoy
2019-03-20 11:02 ` Kirill Shcherbatov
2019-02-27 11:13 ` [tarantool-patches] [PATCH v2 5/7] sql: refactor sql_trigger_step_allocate " Kirill Shcherbatov
2019-03-07 17:34 ` Vladislav Shpilevoy [this message]
2019-03-11 15:04 ` [tarantool-patches] " Kirill Shcherbatov
2019-03-18 19:33 ` Vladislav Shpilevoy
2019-03-20 11:02 ` Kirill Shcherbatov
2019-03-26 17:08 ` Vladislav Shpilevoy
2019-02-27 11:13 ` [tarantool-patches] [PATCH v2 6/7] sql: refactor sql_expr_create " Kirill Shcherbatov
2019-03-07 17:34 ` [tarantool-patches] " Vladislav Shpilevoy
2019-03-11 15:04 ` Kirill Shcherbatov
2019-03-18 19:33 ` Vladislav Shpilevoy
2019-03-20 11:02 ` Kirill Shcherbatov
2019-03-26 17:08 ` Vladislav Shpilevoy
2019-02-27 11:13 ` [tarantool-patches] [PATCH v2 7/7] sql: store regular identifiers in case-normal form Kirill Shcherbatov
2019-03-07 17:34 ` [tarantool-patches] " Vladislav Shpilevoy
2019-03-11 15:04 ` Kirill Shcherbatov
2019-03-18 19:33 ` Vladislav Shpilevoy
2019-03-20 11:02 ` Kirill Shcherbatov
2019-03-26 17:08 ` Vladislav Shpilevoy
2019-03-18 19:33 ` [tarantool-patches] Re: [PATCH v2 0/7] " Vladislav Shpilevoy
2019-03-20 11:02 ` Kirill Shcherbatov
2019-03-26 17:09 ` Vladislav Shpilevoy
2019-03-27 14:06 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=403432db-e4b7-fc6f-73bb-13a98ec2959f@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2 5/7] sql: refactor sql_trigger_step_allocate to set diag' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox