From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>,
Chris Sosnin <k.sosnin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/2] sql: drop only generated sequence in DROP TABLE
Date: Tue, 24 Dec 2019 17:26:11 +0100 [thread overview]
Message-ID: <400814c8-b019-11d8-1cc6-1b9a6ccbdc22@tarantool.org> (raw)
In-Reply-To: <20191224012307.GA49851@tarantool.org>
Thanks for the review!
On 24/12/2019 02:23, Nikita Pettik wrote:
> On 18 Dec 14:00, Chris Sosnin wrote:
>> create mode 100644 test/sql/autoincrement.result
>> create mode 100644 test/sql/autoincrement.test.lua
>>
>> diff --git a/test/sql/autoincrement.test.lua b/test/sql/autoincrement.test.lua
>
> Patch itself is LGTM (as obvious). But I am not a big fan of placing each
> test in separate file (at least when there's no specific issue for that).
As you know, me neither. I added this new file to put here all
autoincrement stuff now and in future. We have sql-tap/autoinc,
but sql-tap tests are really hard to write and fix.
> Moreover, in commit message it is said that this patch is follow-up to
> #4546, so could you move this test to gh-4546-sql-drop-grants.test.lua ?
4546 was about table grants. The test in autoincrement file about a
different bug - drop of sequence. It is kinda related to 4546 in that
sequence grants also should be dropped, if their sequence is deleted.
next prev parent reply other threads:[~2019-12-24 16:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 12:53 [Tarantool-patches] [PATCH] sql: remove grants associated with the table Chris Sosnin
2019-12-07 10:29 ` Chris Sosnin
2019-12-10 23:45 ` Vladislav Shpilevoy
2019-12-11 9:50 ` Chris Sosnin
2019-12-17 23:13 ` Vladislav Shpilevoy
2019-12-17 23:13 ` Vladislav Shpilevoy
2019-12-18 11:00 ` [Tarantool-patches] [PATCH 0/2] sql: revoke table privileges on drop Chris Sosnin
2019-12-18 11:00 ` [Tarantool-patches] [PATCH 1/2] sql: remove grants associated with the table Chris Sosnin
2019-12-24 1:37 ` Nikita Pettik
2019-12-24 16:47 ` Vladislav Shpilevoy
2019-12-18 11:00 ` [Tarantool-patches] [PATCH 2/2] sql: drop only generated sequence in DROP TABLE Chris Sosnin
2019-12-24 1:23 ` Nikita Pettik
2019-12-24 16:26 ` Vladislav Shpilevoy [this message]
2019-12-24 23:19 ` Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=400814c8-b019-11d8-1cc6-1b9a6ccbdc22@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=k.sosnin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/2] sql: drop only generated sequence in DROP TABLE' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox