[Tarantool-patches] [PATCH luajit] codehealth: add `nd` to the codespell ignore list

[Tarantool-patches] [PATCH luajit] codehealth: add `nd` to the codespell ignore list

[Sergey Kaplun via Tarantool-patches]

This patch is a follow-up to the
15acf5b2ff3841e757434e63394de97662a17e81 ("Fix zero stripping in %g
number formatting."). `nd` is used as a stack buffer for number
formatting and mentioned in the test comment. This patch adds it to the
ignore list to avoid false-positives for comments like "nd ==> and, 2nd"
for codespell version 2.2.6.

Also, it sorts the ignore list for better readability.
---

Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-codespell-nd

 .codespell-ignore-words.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.codespell-ignore-words.txt b/.codespell-ignore-words.txt
index dcdc12f7..757ee53d 100644
--- a/.codespell-ignore-words.txt
+++ b/.codespell-ignore-words.txt
@@ -1,2 +1,3 @@
-isnt
 fpr
+isnt
+nd
-- 
2.43.0

Re: [Tarantool-patches] [PATCH luajit] codehealth: add `nd` to the codespell ignore list

[Sergey Bronnikov via Tarantool-patches]

Hi, Sergey

thanks for the patch! LGTM

On 2/7/24 15:39, Sergey Kaplun wrote:
> This patch is a follow-up to the
> 15acf5b2ff3841e757434e63394de97662a17e81 ("Fix zero stripping in %g
> number formatting."). `nd` is used as a stack buffer for number
> formatting and mentioned in the test comment. This patch adds it to the
> ignore list to avoid false-positives for comments like "nd ==> and, 2nd"
> for codespell version 2.2.6.
>
> Also, it sorts the ignore list for better readability.
> ---
>
> Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-codespell-nd
>
>   .codespell-ignore-words.txt | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/.codespell-ignore-words.txt b/.codespell-ignore-words.txt
> index dcdc12f7..757ee53d 100644
> --- a/.codespell-ignore-words.txt
> +++ b/.codespell-ignore-words.txt
> @@ -1,2 +1,3 @@
> -isnt
>   fpr
> +isnt
> +nd

Re: [Tarantool-patches] [PATCH luajit] codehealth: add `nd` to the codespell ignore list

[Maxim Kokryashkin via Tarantool-patches]

Hi, Sergey!
Thanks for the patch!
LGTM
On Wed, Feb 07, 2024 at 03:39:46PM +0300, Sergey Kaplun wrote:
> This patch is a follow-up to the
> 15acf5b2ff3841e757434e63394de97662a17e81 ("Fix zero stripping in %g
> number formatting."). `nd` is used as a stack buffer for number
> formatting and mentioned in the test comment. This patch adds it to the
> ignore list to avoid false-positives for comments like "nd ==> and, 2nd"
> for codespell version 2.2.6.
>
> Also, it sorts the ignore list for better readability.
> ---
>
> Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-codespell-nd
>
>  .codespell-ignore-words.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/.codespell-ignore-words.txt b/.codespell-ignore-words.txt
> index dcdc12f7..757ee53d 100644
> --- a/.codespell-ignore-words.txt
> +++ b/.codespell-ignore-words.txt
> @@ -1,2 +1,3 @@
> -isnt
>  fpr
> +isnt
> +nd
> --
> 2.43.0
>

Re: [Tarantool-patches] [PATCH luajit] codehealth: add `nd` to the codespell ignore list

[Igor Munkin via Tarantool-patches]

Sergey,

I've checked the patchset into all long-term branches in
tarantool/luajit and bumped a new version in master, release/3.0 and
release/2.11.

On 07.02.24, Sergey Kaplun via Tarantool-patches wrote:
> This patch is a follow-up to the
> 15acf5b2ff3841e757434e63394de97662a17e81 ("Fix zero stripping in %g
> number formatting."). `nd` is used as a stack buffer for number
> formatting and mentioned in the test comment. This patch adds it to the
> ignore list to avoid false-positives for comments like "nd ==> and, 2nd"
> for codespell version 2.2.6.
> 
> Also, it sorts the ignore list for better readability.
> ---
> 
> Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-codespell-nd
> 
>  .codespell-ignore-words.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/.codespell-ignore-words.txt b/.codespell-ignore-words.txt
> index dcdc12f7..757ee53d 100644
> --- a/.codespell-ignore-words.txt
> +++ b/.codespell-ignore-words.txt
> @@ -1,2 +1,3 @@
> -isnt
>  fpr
> +isnt
> +nd
> -- 
> 2.43.0
> 

-- 
Best regards,
IM