From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] codehealth: add `nd` to the codespell ignore list
Date: Fri, 9 Feb 2024 19:22:34 +0300 [thread overview]
Message-ID: <3us33d5vouirlumyybne4nqnolchenziagupphtq5p6cucrohr@qfnglq774h7p> (raw)
In-Reply-To: <20240207123946.24326-1-skaplun@tarantool.org>
Hi, Sergey!
Thanks for the patch!
LGTM
On Wed, Feb 07, 2024 at 03:39:46PM +0300, Sergey Kaplun wrote:
> This patch is a follow-up to the
> 15acf5b2ff3841e757434e63394de97662a17e81 ("Fix zero stripping in %g
> number formatting."). `nd` is used as a stack buffer for number
> formatting and mentioned in the test comment. This patch adds it to the
> ignore list to avoid false-positives for comments like "nd ==> and, 2nd"
> for codespell version 2.2.6.
>
> Also, it sorts the ignore list for better readability.
> ---
>
> Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-codespell-nd
>
> .codespell-ignore-words.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/.codespell-ignore-words.txt b/.codespell-ignore-words.txt
> index dcdc12f7..757ee53d 100644
> --- a/.codespell-ignore-words.txt
> +++ b/.codespell-ignore-words.txt
> @@ -1,2 +1,3 @@
> -isnt
> fpr
> +isnt
> +nd
> --
> 2.43.0
>
next prev parent reply other threads:[~2024-02-09 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 12:39 Sergey Kaplun via Tarantool-patches
2024-02-08 9:27 ` Sergey Bronnikov via Tarantool-patches
2024-02-09 16:22 ` Maxim Kokryashkin via Tarantool-patches [this message]
2024-02-15 13:51 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3us33d5vouirlumyybne4nqnolchenziagupphtq5p6cucrohr@qfnglq774h7p \
--to=tarantool-patches@dev.tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] codehealth: add `nd` to the codespell ignore list' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox