Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org, imeevma@tarantool.org
Cc: korablev@tarantool.org
Subject: [tarantool-patches] Re: [PATCH v5 3/6] sql: Show currently set sql_default_engine
Date: Wed, 30 Jan 2019 16:57:00 +0300	[thread overview]
Message-ID: <3ec5bc03-c10c-243f-fa51-ec471676a347@tarantool.org> (raw)
In-Reply-To: <afa6d1d84dc901192ae9230293709568961668cd.1548771900.git.imeevma@gmail.com>



On 29/01/2019 17:29, imeevma@tarantool.org wrote:
> After this patch, "PRAGMA sql_default_engine" called without
> arguments will return currently set sql_default_engine.
> ---
>   src/box/sql/pragma.c                 | 18 +++++++++++++-----
>   test/sql-tap/gh-2367-pragma.test.lua | 35 +++++++++++++++++++++++++++--------
>   2 files changed, 40 insertions(+), 13 deletions(-)
> 
> diff --git a/test/sql-tap/gh-2367-pragma.test.lua b/test/sql-tap/gh-2367-pragma.test.lua
> index c0792c9..90ecd56 100755
> --- a/test/sql-tap/gh-2367-pragma.test.lua
> +++ b/test/sql-tap/gh-2367-pragma.test.lua
> +--
> +-- gh-3832: Some statements do not return column type
> +--
> +-- Check that "PRAGMA sql_default_engine" called without arguments
> +-- returns currently set sql_default_engine.
>   test:do_catchsql_test(
> -	"pragma-2.5",
> +	"pragma-3.1",
>   	[[
> -		pragma sql_default_engine 1;
> +		pragma sql_default_engine='vinyl';
> +		pragma sql_default_engine;
>   	]], {
> -	1, 'near \"1\": syntax error'
> +	-- <pragma-3.1>
> +	0, {'vinyl'}
> +	-- <pragma-3.1>

If a test does not fail, you should not use
test:do_catchsql_test. We have do_test for this.

Also, this file is named gh-2367-***, but you added
here a test for gh-3832. This is why it made no
sense to create a new file on each issue. Please,
rename it to pragma.test.lua.

> +})
> +
> +test:do_catchsql_test(
> +	"pragma-3.2",
> +	[[
> +		pragma sql_default_engine='memtx';
> +		pragma sql_default_engine;
> +	]], {
> +	-- <pragma-3.2>
> +	0, {'memtx'}
> +	-- <pragma-3.2>
>   })
>   
>   test:finish_test()
> -- 
> 2.7.4
> 
> 

  reply	other threads:[~2019-01-30 13:57 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29 14:29 [tarantool-patches] [PATCH v5 0/6] sql: set column types for EXPLAIN and PRAGMA imeevma
2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 1/6] sql: remove unused macros from pragma.c and pragma.h imeevma
2019-01-30 13:57   ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-31 14:56     ` Imeev Mergen
2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 2/6] sql: fix "PRAGMA parser_trace" result imeevma
2019-01-30 13:57   ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-31 14:56     ` Imeev Mergen
2019-02-04 13:06       ` Vladislav Shpilevoy
2019-02-09 10:08         ` Mergen Imeev
2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 3/6] sql: Show currently set sql_default_engine imeevma
2019-01-30 13:57   ` Vladislav Shpilevoy [this message]
2019-01-31 14:56     ` [tarantool-patches] " Imeev Mergen
2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 4/6] sql: fix "PRAGMA case_sensitive_like" result imeevma
2019-01-30 13:56   ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-31 14:56     ` Imeev Mergen
2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 5/6] sql: get results of PRAGMA statement in YAML format imeevma
2019-01-30 13:56   ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-31 14:56     ` Imeev Mergen
2019-02-04 13:08       ` Vladislav Shpilevoy
2019-02-09 10:11         ` Mergen Imeev
2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 6/6] sql: set column types for EXPLAIN and PRAGMA imeevma
2019-01-30 13:59 ` [tarantool-patches] Re: [PATCH v5 0/6] " Vladislav Shpilevoy
2019-01-31 14:56   ` Imeev Mergen
2019-02-15 20:44 ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ec5bc03-c10c-243f-fa51-ec471676a347@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v5 3/6] sql: Show currently set sql_default_engine' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox