From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: imeevma@tarantool.org, korablev@tarantool.org,
tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v7 0/2] sql: return all generated ids via IPROTO
Date: Mon, 29 Oct 2018 00:28:17 +0300 [thread overview]
Message-ID: <3e406ab2-2f5d-fe9e-4a2c-41eaed34bc21@tarantool.org> (raw)
In-Reply-To: <cover.1540638002.git.imeevma@gmail.com>
Hi! Nikita, please, ignore this. It contains a bug.
On 27/10/2018 14:18, imeevma@tarantool.org wrote:
> To make implementation of function getGeneratedKeys() of JDBC
> driver we should be able to return information of generated keys
> through IPROTO.
>
> Patch 1 implements such functionality.
>
> Patch 2 do some refactoring in VDBE.
>
> Issue: https://github.com/tarantool/tarantool/issues/2618
> Branch: https://github.com/tarantool/tarantool/tree/imeevma/gh-2618-return-all-generated-ids
>
> Mergen Imeev (1):
> sql: return all generated ids via IPROTO
>
> Vladislav Shpilevoy (1):
> sql: remove psql_txn from Vdbe
>
> src/box/execute.c | 28 ++++++++++++++-
> src/box/execute.h | 1 +
> src/box/lua/net_box.c | 29 ++++++++++++---
> src/box/sequence.c | 7 ++++
> src/box/sequence.h | 13 +++++++
> src/box/sql/vdbe.c | 42 +++++++++++++++++-----
> src/box/sql/vdbe.h | 12 ++++++-
> src/box/sql/vdbeInt.h | 7 ++--
> src/box/sql/vdbeaux.c | 25 ++++++-------
> src/box/txn.h | 27 ++++++++++++++
> test/sql/iproto.result | 92 ++++++++++++++++++++++++++++++++++++++++++++++++
> test/sql/iproto.test.lua | 24 +++++++++++++
> 12 files changed, 277 insertions(+), 30 deletions(-)
>
next prev parent reply other threads:[~2018-10-28 21:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 11:18 [tarantool-patches] " imeevma
2018-10-27 11:18 ` [tarantool-patches] [PATCH v7 1/2] " imeevma
2018-11-01 12:21 ` [tarantool-patches] " Konstantin Osipov
2018-10-27 11:18 ` [tarantool-patches] [PATCH v7 2/2] sql: remove psql_txn from Vdbe imeevma
2018-10-28 21:28 ` Vladislav Shpilevoy [this message]
2018-10-29 0:37 ` [tarantool-patches] Re: [PATCH v7 0/2] sql: return all generated ids via IPROTO n.pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e406ab2-2f5d-fe9e-4a2c-41eaed34bc21@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v7 0/2] sql: return all generated ids via IPROTO' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox