From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: tarantool-patches@freelists.org, imeevma@tarantool.org Cc: korablev@tarantool.org Subject: [tarantool-patches] Re: [PATCH v5 2/6] sql: fix "PRAGMA parser_trace" result Date: Wed, 30 Jan 2019 16:57:01 +0300 [thread overview] Message-ID: <3e0c44e3-21fc-8288-c877-da8fe5996758@tarantool.org> (raw) In-Reply-To: <e922f268e14860475060932acdb7573f39bc0535.1548771900.git.imeevma@gmail.com> On 29/01/2019 17:29, imeevma@tarantool.org wrote: > Currently PRAGMA parser_trace returns an empty table. This seems > wrong, since other similar pragmas return their status. Fixed in > the current patch. > --- > src/box/sql/pragma.c | 59 +++++++++++++++++---------------------------- > src/box/sql/pragma.h | 7 +++--- > src/box/sql/sqliteInt.h | 2 ++ > test/sql/sql-debug.result | 29 ++++++++++++++++++++++ > test/sql/sql-debug.test.lua | 14 +++++++++++ > test/sql/suite.ini | 2 +- > 6 files changed, 71 insertions(+), 42 deletions(-) > create mode 100644 test/sql/sql-debug.result > create mode 100644 test/sql/sql-debug.test.lua > > diff --git a/test/sql/sql-debug.result b/test/sql/sql-debug.result > new file mode 100644 > index 0000000..0c9ac97 > --- /dev/null > +++ b/test/sql/sql-debug.result > @@ -0,0 +1,29 @@ > +remote = require('net.box') > +--- > +... > +test_run = require('test_run').new() > +--- > +... > +engine = test_run:get_cfg('engine') Why do you need an engine here? This test never touches the data dictionary. > +--- > +... > +box.sql.execute('pragma sql_default_engine=\''..engine..'\'') > +--- > +... > +-- > +-- gh-3832: Some statements do not return column type > +-- Check that "PRAGMA parser_trace" returns 0 or 1 if called > +-- without parameter. > +result = box.sql.execute('PRAGMA parser_trace') > +--- > +... > +box.sql.execute('PRAGMA parser_trace = 1') > +--- > +... > +box.sql.execute('PRAGMA parser_trace') > +--- > +- - [1] > +... > +box.sql.execute('PRAGMA parser_trace = '.. result[1][1]) > +--- > +...
next prev parent reply other threads:[~2019-01-30 13:57 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-29 14:29 [tarantool-patches] [PATCH v5 0/6] sql: set column types for EXPLAIN and PRAGMA imeevma 2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 1/6] sql: remove unused macros from pragma.c and pragma.h imeevma 2019-01-30 13:57 ` [tarantool-patches] " Vladislav Shpilevoy 2019-01-31 14:56 ` Imeev Mergen 2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 2/6] sql: fix "PRAGMA parser_trace" result imeevma 2019-01-30 13:57 ` Vladislav Shpilevoy [this message] 2019-01-31 14:56 ` [tarantool-patches] " Imeev Mergen 2019-02-04 13:06 ` Vladislav Shpilevoy 2019-02-09 10:08 ` Mergen Imeev 2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 3/6] sql: Show currently set sql_default_engine imeevma 2019-01-30 13:57 ` [tarantool-patches] " Vladislav Shpilevoy 2019-01-31 14:56 ` Imeev Mergen 2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 4/6] sql: fix "PRAGMA case_sensitive_like" result imeevma 2019-01-30 13:56 ` [tarantool-patches] " Vladislav Shpilevoy 2019-01-31 14:56 ` Imeev Mergen 2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 5/6] sql: get results of PRAGMA statement in YAML format imeevma 2019-01-30 13:56 ` [tarantool-patches] " Vladislav Shpilevoy 2019-01-31 14:56 ` Imeev Mergen 2019-02-04 13:08 ` Vladislav Shpilevoy 2019-02-09 10:11 ` Mergen Imeev 2019-01-29 14:29 ` [tarantool-patches] [PATCH v5 6/6] sql: set column types for EXPLAIN and PRAGMA imeevma 2019-01-30 13:59 ` [tarantool-patches] Re: [PATCH v5 0/6] " Vladislav Shpilevoy 2019-01-31 14:56 ` Imeev Mergen 2019-02-15 20:44 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3e0c44e3-21fc-8288-c877-da8fe5996758@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=imeevma@tarantool.org \ --cc=korablev@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v5 2/6] sql: fix "PRAGMA parser_trace" result' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox