From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v16 0/3] qsync: implement packet filtering (part 1)
Date: Thu, 16 Sep 2021 00:51:37 +0200 [thread overview]
Message-ID: <3d06cce4-3350-35fe-5655-450f91ab0678@tarantool.org> (raw)
In-Reply-To: <20210915145046.133303-1-gorcunov@gmail.com>
On 15.09.2021 16:50, Cyrill Gorcunov via Tarantool-patches wrote:
> Packet filtering takes more and more time to implement and I send
> similar patches again multiple times. Still the complete split brain
> detection is not yet done, so I thought it might be worth to split the
> work into several series. This part addresses a race with terms manipulation
> and I think can be considered as its own.
>
> I would really appreciate comments here mostly due to function naming,
> comments and etc. My primary aim was to make sure that this series doesn't
> break anything existing but I think if we would have a test case for this
> ordering issue it would be brilliant, though I didn't come with some simple
> one here yet.
Committing a part of the series won't speed up the other patches, unfortunately.
If you think something can be done separately, it is a good idea. But still
such changes must be independent and have their own tests then.
Just pushing some first commits won't help with the next ones.
next prev parent reply other threads:[~2021-09-15 22:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 14:50 Cyrill Gorcunov via Tarantool-patches
2021-09-15 14:50 ` [Tarantool-patches] [PATCH v16 1/3] latch: add latch_is_locked helper Cyrill Gorcunov via Tarantool-patches
2021-09-15 14:50 ` [Tarantool-patches] [PATCH v16 2/3] qsync: order access to the limbo terms Cyrill Gorcunov via Tarantool-patches
2021-09-15 14:50 ` [Tarantool-patches] [PATCH v16 3/3] qsync: track confirmed_lsn upon CONFIRM packet Cyrill Gorcunov via Tarantool-patches
2021-09-15 22:51 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-09-16 10:50 ` [Tarantool-patches] [PATCH v16 0/3] qsync: implement packet filtering (part 1) Cyrill Gorcunov via Tarantool-patches
2021-09-20 15:22 ` [Tarantool-patches] [PATCH 4/3] test: add gh-6036-term-order test Cyrill Gorcunov via Tarantool-patches
2021-09-21 8:51 ` Cyrill Gorcunov via Tarantool-patches
2021-09-22 13:00 ` [Tarantool-patches] [PATCH v16 0/3] qsync: implement packet filtering (part 1) Cyrill Gorcunov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d06cce4-3350-35fe-5655-450f91ab0678@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v16 0/3] qsync: implement packet filtering (part 1)' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox