From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 963016FC86; Thu, 16 Sep 2021 01:51:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 963016FC86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1631746299; bh=zOk4Qi28CCBG9KoiAp0oXnGnTxVRqNWgMTfMvu5fzaM=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=UERpfnDE+mQaq6ua4PLP4AVYtkkNaMBm1VNEn/ZndjRlbOyMNlMW/rSjn04+X0Ek9 AIFIfNn61WTk9ELubbkn2RqNUhMn+ABwd4R5YPmhD8sEn/aGDHX3gMHCdGOxxmNphE cjVTn3rMB5AoliuwifMH41+GCao0+S/sHuGB1K3g= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A57AC6FC86 for ; Thu, 16 Sep 2021 01:51:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A57AC6FC86 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1mQdkg-0006ca-11; Thu, 16 Sep 2021 01:51:38 +0300 To: Cyrill Gorcunov , tml References: <20210915145046.133303-1-gorcunov@gmail.com> Message-ID: <3d06cce4-3350-35fe-5655-450f91ab0678@tarantool.org> Date: Thu, 16 Sep 2021 00:51:37 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210915145046.133303-1-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD91AE02D33A9C88A2F7B0FCECE251A4B9EABD2FC9AA46919D800894C459B0CD1B9697F8858D4E8FB96A6E95B574DF42C4D42C97DCEBCEACBE3B69AF26CEA7F1A08 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F1942E6D70B4A2F0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063786F1F539FBE87B778638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8AB5BB4DC32A148613CA925A632DCC364117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B08F9A42B2210255C75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B5054D862CB0D9C51FA26EFB14EF6698C37E X-C1DE0DAB: 0D63561A33F958A5269965D6D01A3BD4231456A0137432F4043A2014F40092E0D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C0DDD40374D35017F1F56614FF09300E7F4B5A62B456F9F38B734285FEE13E03A101DCF6501710361D7E09C32AA3244CC3A3ED9650D7F02255BAED061C466EA033C9DC155518937F729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojmwY/hTp72s8GswOUrd+tFw== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DBCC177B7273973D97BA18BD558644F823841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v16 0/3] qsync: implement packet filtering (part 1) X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 15.09.2021 16:50, Cyrill Gorcunov via Tarantool-patches wrote: > Packet filtering takes more and more time to implement and I send > similar patches again multiple times. Still the complete split brain > detection is not yet done, so I thought it might be worth to split the > work into several series. This part addresses a race with terms manipulation > and I think can be considered as its own. > > I would really appreciate comments here mostly due to function naming, > comments and etc. My primary aim was to make sure that this series doesn't > break anything existing but I think if we would have a test case for this > ordering issue it would be brilliant, though I didn't come with some simple > one here yet. Committing a part of the series won't speed up the other patches, unfortunately. If you think something can be done separately, it is a good idea. But still such changes must be independent and have their own tests then. Just pushing some first commits won't help with the next ones.