From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] Prevent snapshot purge while recording a function header.
Date: Tue, 10 Mar 2026 17:19:45 +0300 [thread overview]
Message-ID: <3bc1b0da-6c28-46a9-8f69-2a27cce60088@tarantool.org> (raw)
In-Reply-To: <aabNkgwhK_MXVKX1@root>
[-- Attachment #1: Type: text/plain, Size: 972 bytes --]
Hi, Sergey!
On 3/3/26 15:01, Sergey Kaplun wrote:
> Hi, Sergey!
> Thanks for the review!
> See my answer below.
>
> On 03.03.26, Sergey Bronnikov wrote:
>> Hi, Sergey,
>>
>> thanks for the patch! LGTM with a minor comment.
>>
>> Sergey
>>
>> On 2/25/26 15:11, Sergey Kaplun wrote:
> <snipped>
>
>>> +
>>> +local checkers = {}
>>> +
>>> +-- Called twice for the pseudo-type that aliases base Lua type via
>>> +-- checkers map.
>>> +local function checks(expected_type)
>>> + -- Value expected to be `checks_tab()` or `checks_obj()`
>>> + -- argument. It is always a table.
>>> + local _, value = debug_getlocal(2, 1)
>>> + -- Simple stitching function. Additional arguments are needed to
>>> + -- occupy the corresponding slot.
>> It is not clear for me why this corresponding slot is needed.
>>
>> The bug can be reproduced without double nil's passed to math_modf().
> Not for all builds (i.e. GC64 and non-GC64).
ok, thanks for the answer!
LGTM then
<snipped>
[-- Attachment #2: Type: text/html, Size: 1770 bytes --]
prev parent reply other threads:[~2026-03-10 14:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 12:11 Sergey Kaplun via Tarantool-patches
2026-03-03 10:44 ` Sergey Bronnikov via Tarantool-patches
2026-03-03 12:01 ` Sergey Kaplun via Tarantool-patches
2026-03-10 14:19 ` Sergey Bronnikov via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bc1b0da-6c28-46a9-8f69-2a27cce60088@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] Prevent snapshot purge while recording a function header.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox