Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>,
	tarantool-patches@freelists.org
Cc: Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 2/2] sql: remove struct Enc
Date: Tue, 28 Aug 2018 20:21:17 -0300	[thread overview]
Message-ID: <3ac248e9-a52f-7549-cdf6-024a4c48ea2a@tarantool.org> (raw)
In-Reply-To: <b88b085a-ef55-c9bf-f04e-568b117f351b@tarantool.org>

Thanks for the fixes! Now the whole patchset LGTM.

As I know, for Nikita as well, so Kirill Yu., look at
it, please.

>> 4. Finish a sentence with the dot. Btw the comment
>> is not related to the code. Below you do not whether
>> the index is unique or not.
>> 5. "Did't defined" - corrupted phrase. Rather "did't define".
>> But the whole comment looks strange as well as the previous,
>> and out of its place. Just remove it.
> You know, I've just copied existed peace of code with all comments.
> I've get rid off those two comments at all now.

I know, but it is not an excuse. After the patch was pushed, git blame
would show your name against these lines.

  reply	other threads:[~2018-08-28 23:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-27 11:11 [tarantool-patches] [PATCH v2 0/2] " Kirill Shcherbatov
2018-08-27 11:11 ` [tarantool-patches] [PATCH v2 1/2] box: export mpstream methods to core Kirill Shcherbatov
2018-08-28  1:43   ` [tarantool-patches] " Vladislav Shpilevoy
2018-08-28  6:46     ` Kirill Shcherbatov
2018-08-27 11:11 ` [tarantool-patches] [PATCH v2 2/2] sql: remove struct Enc Kirill Shcherbatov
2018-08-28  1:43   ` [tarantool-patches] " Vladislav Shpilevoy
2018-08-28  6:46     ` Kirill Shcherbatov
2018-08-28 23:21       ` Vladislav Shpilevoy [this message]
2018-08-28  1:43 ` [tarantool-patches] Re: [PATCH v2 0/2] " Vladislav Shpilevoy
2018-08-29 14:12 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ac248e9-a52f-7549-cdf6-024a4c48ea2a@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=kshcherbatov@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v2 2/2] sql: remove struct Enc' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox