Tarantool development patches archive
 help / color / mirror / Atom feed
From: Roman Khabibov <roman.habibov@tarantool.org>
To: tarantool-patches@dev.tarantool.org
Cc: v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v4 0/6] Support column addition
Date: Sat, 12 Sep 2020 01:00:41 +0300	[thread overview]
Message-ID: <3A027E12-DF9C-4FF9-88B5-3F5547BD2E33@tarantool.org> (raw)
In-Reply-To: <20200911215115.6622-1-roman.habibov@tarantool.org>

Sorry, forgot about

@ChangeLog
* Support <ALTER TABLE ADD COLUMN> statement (gh-3075).
* Ban possibility to modify field_count and format of a view (gh-####).


> On Sep 12, 2020, at 00:51, Roman Khabibov <roman.habibov@tarantool.org> wrote:
> 
> There is two new patches:
> 
> sql: use parser's region of index array
> box: disallow to modify format of a view
> 
> I'm not sure, should I write that they are "needed for"?
> 
> Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-3075-add-column-v2
> Issue: https://github.com/tarantool/tarantool/issues/3075
> 
> Roman Khabibov (6):
>  sql: rename TK_COLUMN to TK_COLUMN_NAME
>  sql: refactor create_table_def and parse
>  schema: add box_space_field_MAX
>  sql: use parser's region of "index" array
>  box: disallow to modify format of a view
>  sql: support column addition
> 
> extra/addopcodes.sh                       |   2 +-
> extra/mkkeywordhash.c                     |   7 +-
> src/box/alter.cc                          |   8 +
> src/box/errcode.h                         |   1 +
> src/box/schema_def.h                      |   1 +
> src/box/sql/build.c                       | 605 +++++++++++++++-------
> src/box/sql/expr.c                        |  48 +-
> src/box/sql/fk_constraint.c               |   2 +-
> src/box/sql/parse.y                       |  48 +-
> src/box/sql/parse_def.h                   |  79 +--
> src/box/sql/prepare.c                     |   3 +-
> src/box/sql/resolve.c                     |  10 +-
> src/box/sql/select.c                      |  10 +-
> src/box/sql/sqlInt.h                      |  59 ++-
> src/box/sql/treeview.c                    |   2 +-
> src/box/sql/where.c                       |  18 +-
> src/box/sql/whereexpr.c                   |  12 +-
> test/box/error.result                     |   1 +
> test/box/view-dont-modify-format.result   |  51 ++
> test/box/view-dont-modify-format.test.lua |  18 +
> test/sql/add-column.result                | 529 +++++++++++++++++++
> test/sql/add-column.test.sql              | 183 +++++++
> test/sql/checks.result                    |  20 +
> test/sql/checks.test.lua                  |   9 +
> test/sql/foreign-keys.result              |  28 +
> test/sql/foreign-keys.test.lua            |  11 +
> 26 files changed, 1475 insertions(+), 290 deletions(-)
> create mode 100644 test/box/view-dont-modify-format.result
> create mode 100644 test/box/view-dont-modify-format.test.lua
> create mode 100644 test/sql/add-column.result
> create mode 100644 test/sql/add-column.test.sql
> 
> -- 
> 2.24.3 (Apple Git-128)
> 

  parent reply	other threads:[~2020-09-11 22:00 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11 21:51 Roman Khabibov
2020-09-11 21:51 ` [Tarantool-patches] [PATCH v4 1/6] sql: rename TK_COLUMN to TK_COLUMN_NAME Roman Khabibov
2020-09-16 13:17   ` Nikita Pettik
2020-09-28 23:29     ` Roman Khabibov
2020-09-11 21:51 ` [Tarantool-patches] [PATCH v4 2/6] sql: refactor create_table_def and parse Roman Khabibov
2020-09-16 13:27   ` Nikita Pettik
2020-09-17 14:43     ` Vladislav Shpilevoy
2020-09-18 12:31       ` Nikita Pettik
2020-09-18 13:21         ` Roman Khabibov
2020-09-28 23:29     ` Roman Khabibov
2020-09-17 14:43   ` Vladislav Shpilevoy
2020-10-02 22:08     ` Vladislav Shpilevoy
2020-10-03 21:37     ` Roman Khabibov
2020-10-04 13:45       ` Vladislav Shpilevoy
2020-10-04 21:44         ` Roman Khabibov
2020-10-05 21:22           ` Vladislav Shpilevoy
2020-10-07 13:53             ` Roman Khabibov
2020-10-07 22:35               ` Vladislav Shpilevoy
2020-10-08 10:32                 ` Roman Khabibov
2020-09-17 15:16   ` Vladislav Shpilevoy
2020-10-02 22:08     ` Vladislav Shpilevoy
2020-09-11 21:51 ` [Tarantool-patches] [PATCH v4 3/6] schema: add box_space_field_MAX Roman Khabibov
2020-09-11 21:51 ` [Tarantool-patches] [PATCH v4 4/6] sql: use parser's region of "index" array Roman Khabibov
2020-09-16 13:30   ` Nikita Pettik
2020-09-28 23:29     ` Roman Khabibov
2020-09-17 14:53   ` Vladislav Shpilevoy
2020-09-23 14:25     ` Roman Khabibov
2020-09-24 21:30       ` Vladislav Shpilevoy
2020-10-05 21:22   ` Vladislav Shpilevoy
2020-10-07 13:53     ` Roman Khabibov
2020-09-11 21:51 ` [Tarantool-patches] [PATCH v4 5/6] box: disallow to modify format of a view Roman Khabibov
2020-09-16 13:37   ` Nikita Pettik
2020-09-22 15:59     ` Roman Khabibov
2020-09-17 15:01   ` Vladislav Shpilevoy
2020-09-22 15:59     ` Roman Khabibov
2020-09-11 21:51 ` [Tarantool-patches] [PATCH v4 6/6] sql: support column addition Roman Khabibov
2020-09-16 20:18   ` Nikita Pettik
2020-09-17 15:19     ` Vladislav Shpilevoy
2020-09-18 12:59       ` Nikita Pettik
2020-09-28 23:28         ` Roman Khabibov
2020-10-02 22:08           ` Vladislav Shpilevoy
2020-10-03 21:37             ` Roman Khabibov
2020-09-17 15:45   ` Vladislav Shpilevoy
2020-10-04 13:45   ` Vladislav Shpilevoy
2020-10-04 21:44     ` Roman Khabibov
2020-09-11 22:00 ` Roman Khabibov [this message]
2020-10-08 22:07 ` [Tarantool-patches] [PATCH v4 0/6] Support " Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3A027E12-DF9C-4FF9-88B5-3F5547BD2E33@tarantool.org \
    --to=roman.habibov@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v4 0/6] Support column addition' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox