From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8AA2C469719 for ; Sat, 12 Sep 2020 01:00:42 +0300 (MSK) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) From: Roman Khabibov In-Reply-To: <20200911215115.6622-1-roman.habibov@tarantool.org> Date: Sat, 12 Sep 2020 01:00:41 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <3A027E12-DF9C-4FF9-88B5-3F5547BD2E33@tarantool.org> References: <20200911215115.6622-1-roman.habibov@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v4 0/6] Support column addition List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@dev.tarantool.org Cc: v.shpilevoy@tarantool.org Sorry, forgot about @ChangeLog * Support statement (gh-3075). * Ban possibility to modify field_count and format of a view (gh-####). > On Sep 12, 2020, at 00:51, Roman Khabibov = wrote: >=20 > There is two new patches: >=20 > sql: use parser's region of index array > box: disallow to modify format of a view >=20 > I'm not sure, should I write that they are "needed for"? >=20 > Branch: = https://github.com/tarantool/tarantool/tree/romanhabibov/gh-3075-add-colum= n-v2 > Issue: https://github.com/tarantool/tarantool/issues/3075 >=20 > Roman Khabibov (6): > sql: rename TK_COLUMN to TK_COLUMN_NAME > sql: refactor create_table_def and parse > schema: add box_space_field_MAX > sql: use parser's region of "index" array > box: disallow to modify format of a view > sql: support column addition >=20 > extra/addopcodes.sh | 2 +- > extra/mkkeywordhash.c | 7 +- > src/box/alter.cc | 8 + > src/box/errcode.h | 1 + > src/box/schema_def.h | 1 + > src/box/sql/build.c | 605 +++++++++++++++------- > src/box/sql/expr.c | 48 +- > src/box/sql/fk_constraint.c | 2 +- > src/box/sql/parse.y | 48 +- > src/box/sql/parse_def.h | 79 +-- > src/box/sql/prepare.c | 3 +- > src/box/sql/resolve.c | 10 +- > src/box/sql/select.c | 10 +- > src/box/sql/sqlInt.h | 59 ++- > src/box/sql/treeview.c | 2 +- > src/box/sql/where.c | 18 +- > src/box/sql/whereexpr.c | 12 +- > test/box/error.result | 1 + > test/box/view-dont-modify-format.result | 51 ++ > test/box/view-dont-modify-format.test.lua | 18 + > test/sql/add-column.result | 529 +++++++++++++++++++ > test/sql/add-column.test.sql | 183 +++++++ > test/sql/checks.result | 20 + > test/sql/checks.test.lua | 9 + > test/sql/foreign-keys.result | 28 + > test/sql/foreign-keys.test.lua | 11 + > 26 files changed, 1475 insertions(+), 290 deletions(-) > create mode 100644 test/box/view-dont-modify-format.result > create mode 100644 test/box/view-dont-modify-format.test.lua > create mode 100644 test/sql/add-column.result > create mode 100644 test/sql/add-column.test.sql >=20 > --=20 > 2.24.3 (Apple Git-128) >=20