Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>,
	tarantool-patches@freelists.org,
	Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: show formated MsgPack BLOB on select
Date: Tue, 3 Jul 2018 16:29:24 +0300	[thread overview]
Message-ID: <397d7f5b-3a1e-18e8-128e-cc006c3ae5cb@tarantool.org> (raw)
In-Reply-To: <9fe4782c-0824-095a-508f-8721282aa24c@tarantool.org>

Hello. Thanks for the patch! I have pushed my fixes on the
branch in a separate commit. Please, look and squash if you
are ok with it.

Nikita, please, look at my changes too, they are not minor.


On 03/07/2018 15:48, Kirill Shcherbatov wrote:
> On 02.07.2018 17:55, n.pettik wrote:
>> Double ‘;’ at the end of line.
>> Except for this, LGTM.
> 
> Vlad, please, take a look when you would have time.
> 

  reply	other threads:[~2018-07-03 13:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02 12:33 [tarantool-patches] " Kirill Shcherbatov
2018-07-02 13:36 ` [tarantool-patches] " n.pettik
2018-07-02 14:23   ` Kirill Shcherbatov
2018-07-02 14:55     ` n.pettik
2018-07-03 12:48       ` Kirill Shcherbatov
2018-07-03 13:29         ` Vladislav Shpilevoy [this message]
2018-07-03 14:02           ` Kirill Shcherbatov
2018-07-04  0:13             ` n.pettik
2018-07-04  6:48               ` Kirill Shcherbatov
2018-07-04 10:44 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=397d7f5b-3a1e-18e8-128e-cc006c3ae5cb@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=kshcherbatov@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: show formated MsgPack BLOB on select' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox