Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org, kyukhin@tarantool.org,
	imeevma@tarantool.org, Mergen Imeev <imeevma@gmail.com>
Subject: [tarantool-patches] Re: [PATCH v10 3/4] sql: create box.execute()
Date: Tue, 2 Apr 2019 12:33:43 +0300	[thread overview]
Message-ID: <39751f26-f3e3-3a35-f112-e9471fa6987e@tarantool.org> (raw)
In-Reply-To: <20190402092232.GQ25072@chai>



On 02/04/2019 12:22, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/04/02 11:29]:
>> On 02/04/2019 11:13, Konstantin Osipov wrote:
>>> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/04/01 23:03]:
>>>> +	if (column_count > 0) {
>>>> +		lua_createtable(L, 0, 2);
>>>> +		lua_sql_get_description(stmt, L, column_count);
>>>> +		lua_setfield(L, -2, "metadata");
>>>
>>> Could we rename lua_qsl_get_description() to
>>> lua_sql_get_metadata() to be consistent in naming?
>>
>> No, we couldn't. Consistent naming is name the methods
>> the same way, and box/execute.c uses term 'description',
>> not 'metadata'.
> 
> Why not rename all the way through, including box/execute.c?

Because I am trying to keep the git history as clean as possible.
But as you wish, as usual. Merge, please, do it.

> 
> -- 
> Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
> http://tarantool.io - www.twitter.com/kostja_osipov
> 

  reply	other threads:[~2019-04-02  9:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 19:59 [tarantool-patches] [PATCH v10 0/4] box.sql.execute removal Vladislav Shpilevoy
2019-04-01 19:59 ` [tarantool-patches] [PATCH v10 1/4] iproto: create port_sql Vladislav Shpilevoy
2019-04-02  8:01   ` [tarantool-patches] " Konstantin Osipov
2019-04-01 19:59 ` [tarantool-patches] [PATCH v10 2/4] sql: export sql_bind structure and API Vladislav Shpilevoy
2019-04-02  8:03   ` [tarantool-patches] " Konstantin Osipov
2019-04-01 19:59 ` [tarantool-patches] [PATCH v10 3/4] sql: create box.execute() Vladislav Shpilevoy
2019-04-02  8:13   ` [tarantool-patches] " Konstantin Osipov
2019-04-02  8:28     ` Vladislav Shpilevoy
2019-04-02  9:22       ` Konstantin Osipov
2019-04-02  9:33         ` Vladislav Shpilevoy [this message]
2019-04-02  9:45           ` Vladislav Shpilevoy
2019-04-02  8:21   ` Konstantin Osipov
2019-04-02  8:34     ` Imeev Mergen
2019-04-02  8:55       ` Konstantin Osipov
2019-04-01 19:59 ` [tarantool-patches] [PATCH v10 4/4] sql: remove box.sql.execute() Vladislav Shpilevoy
2019-04-02  8:19   ` [tarantool-patches] " Konstantin Osipov
2019-04-01 20:02 ` [tarantool-patches] Re: [PATCH v10 0/4] box.sql.execute removal Vladislav Shpilevoy
2019-04-03  7:56 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39751f26-f3e3-3a35-f112-e9471fa6987e@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=imeevma@gmail.com \
    --cc=imeevma@tarantool.org \
    --cc=kostja@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v10 3/4] sql: create box.execute()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox