Re: [Tarantool-patches] [PATCH v8 13/14] test: fix luacheck warnings W621 in test/sql-tap

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Thanks for review!

On 24.01.2021 20:37, Vladislav Shpilevoy wrote:
> Thanks for the patch!
>
> See 2 comments below.
>
> On 21.01.2021 13:50, sergeyb@tarantool.org wrote:
>> From: Sergey Bronnikov <sergeyb@tarantool.org>
>>
>> W621 (Inconsistent indentation (SPACE followed by TAB))
>>
>> Part of #5464
>> ---
>> diff --git a/test/sql-tap/analyze7.test.lua b/test/sql-tap/analyze7.test.lua
>> index 203a0c3f9..8aa29e951 100755
>> --- a/test/sql-tap/analyze7.test.lua
>> +++ b/test/sql-tap/analyze7.test.lua
>> @@ -29,11 +29,11 @@ test:do_test(
>>   		    DROP TABLE IF EXISTS nums;
>>   			CREATE TABLE nums(n  INT PRIMARY KEY);
>>   			INSERT into nums WITH RECURSIVE cnt(x) AS (VALUES(1) UNION ALL SELECT x+1 FROM cnt WHERE x<256) SELECT x FROM cnt;
>> - 			INSERT INTO t1 SELECT n, n, n, n/100, n FROM nums;
>> - 			EXPLAIN QUERY PLAN SELECT * FROM t1 WHERE a=123;
>> +                        INSERT INTO t1 SELECT n, n, n, n/100, n FROM nums;
>> +                        EXPLAIN QUERY PLAN SELECT * FROM t1 WHERE a=123;
>>   		]])
>>   		end, {
>> -        	-- <analyze7-1.0>
>> +                -- <analyze7-1.0>
> 1. This is now misaligned with the next comment.

Reverted


--- a/test/sql-tap/analyze7.test.lua
+++ b/test/sql-tap/analyze7.test.lua
@@ -33,7 +33,7 @@ test:do_test(
                          EXPLAIN QUERY PLAN SELECT * FROM t1 WHERE a=123;
                 ]])
                 end, {
-                -- <analyze7-1.0>
+               -- <analyze7-1.0>
              0, 0, 0, "SEARCH TABLE T1 USING COVERING INDEX T1A (A=?)"
              -- </analyze7-1.0>
          })

>
>>               0, 0, 0, "SEARCH TABLE T1 USING COVERING INDEX T1A (A=?)"
>>               -- </analyze7-1.0>
>>           })
>> diff --git a/test/sql-tap/analyzeD.test.lua b/test/sql-tap/analyzeD.test.lua
>> index e0426b974..c6b9fa206 100755
>> --- a/test/sql-tap/analyzeD.test.lua
>> +++ b/test/sql-tap/analyzeD.test.lua
>> @@ -54,8 +54,8 @@ test:do_test(
>>   			ANALYZE;
>>   		]])
>>   	end, {
>> -        	-- <1.1>
>> -        	-- </1.1>
>> +                -- <1.1>
>> +                -- </1.1>
> 2. You can drop both lines. They are not necessary
> for anything.

Removed


--- a/test/sql-tap/analyzeD.test.lua
+++ b/test/sql-tap/analyzeD.test.lua
@@ -54,8 +54,6 @@ test:do_test(
                         ANALYZE;
                 ]])
         end, {
-                -- <1.1>
-                -- </1.1>
      })

  -- With full ANALYZE data, sql sees that c=150 (5 rows) is better than