From: Kirill Shcherbatov <kshcherbatov@tarantool.org> To: tarantool-patches@freelists.org Cc: Nikita Pettik <korablev@tarantool.org> Subject: [tarantool-patches] Re: [PATCH v2 3/3] sql: enable multi-engine tests for SQL Date: Mon, 2 Jul 2018 11:46:03 +0300 [thread overview] Message-ID: <3961d92b-b56e-8612-e97c-c09ed87ea977@tarantool.org> (raw) In-Reply-To: <84788764-363B-483A-8353-5A3FD61B1F7F@tarantool.org> > Could we disable them for vinyl somehow and run only once? > Some of them take long time to execute. This way: +++ b/test/sql-tap/engine.cfg @@ -1,4 +1,7 @@ { + "analyze9.test.lua": { + "memtx": {"engine": "memtx"} + }, "*": { "memtx": {"engine": "memtx"}, "vinyl": {"engine": "vinyl"} +++ b/test/sql-tap/analyze9.test.lua - pragma sql_default_engine='memtx'; > Lets put newline at the end of file. Ok, fixed on merge. > Please, use types for columns: we are going to introduce static types > in SQL and make them mandatory. -box.sql.execute("CREATE TABLE t1_vinyl(a primary key,b,c);") -box.sql.execute("CREATE TABLE t2_vinyl(a primary key,b,c);") +box.sql.execute("CREATE TABLE t1_vinyl(a INT PRIMARY KEY, b INT, c INT);") +box.sql.execute("CREATE TABLE t2_vinyl(a INT PRIMARY KEY, b INT, c INT);") -box.sql.execute("CREATE TABLE t3_memtx(a primary key,b,c);") +box.sql.execute("CREATE TABLE t3_memtx(a INT PRIMARY KEY, b INT, c INT);")
next prev parent reply other threads:[~2018-07-02 8:46 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-28 16:19 [tarantool-patches] [PATCH v2 0/3] sql: default engine pragma Kirill Shcherbatov 2018-06-28 16:19 ` [tarantool-patches] [PATCH v2 1/3] sql: introduce pragma sql_default_engine Kirill Shcherbatov 2018-06-29 14:00 ` [tarantool-patches] " n.pettik 2018-07-02 8:46 ` Kirill Shcherbatov 2018-07-02 10:23 ` n.pettik 2018-06-28 16:19 ` [tarantool-patches] [PATCH v2 2/3] sql: fix SQL Count for vinyl engine Kirill Shcherbatov 2018-06-28 16:19 ` [tarantool-patches] [PATCH v2 3/3] sql: enable multi-engine tests for SQL Kirill Shcherbatov 2018-06-29 14:14 ` [tarantool-patches] " n.pettik 2018-07-02 8:46 ` Kirill Shcherbatov [this message] 2018-07-03 8:04 ` [tarantool-patches] Re: [PATCH v2 0/3] sql: default engine pragma Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3961d92b-b56e-8612-e97c-c09ed87ea977@tarantool.org \ --to=kshcherbatov@tarantool.org \ --cc=korablev@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v2 3/3] sql: enable multi-engine tests for SQL' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox