From: Serge Petrenko <sergepetrenko@tarantool.org> To: Sergey Bronnikov <sergeyb@tarantool.org> Cc: o.piskunov@tarantool.org, tml <tarantool-patches@dev.tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2] Add infrastructure for fuzzing testing and fuzzers Date: Thu, 30 Apr 2020 16:01:18 +0300 [thread overview] Message-ID: <38eb3f58-becb-cdc4-99f4-1eac40c78491@tarantool.org> (raw) In-Reply-To: <20200430114020.GD12330@pony.bronevichok.ru> 30.04.2020 14:40, Sergey Bronnikov wrote: > Hi, Serge > > On 14:10 Thu 30 Apr , Serge Petrenko wrote: >> diff --git a/cmake/profile.cmake b/cmake/profile.cmake >> index bc4bf67f5..419f7b3cc 100644 >> --- a/cmake/profile.cmake >> +++ b/cmake/profile.cmake >> @@ -42,6 +42,15 @@ else() >> add_definitions(-DNVALGRIND=1) >> endif() >> >> +option(ENABLE_FUZZER "Enable fuzzing testing" OFF) >> +if(ENABLE_FUZZER) >> + if(NOT (CMAKE_C_COMPILER_ID STREQUAL "Clang")) >> + message(WARNING "Fuzzing supported with Clang compiler only.") >> + else() >> + set(TESTING_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/Testing") >> + endif() >> +endif() >> + >> option(ENABLE_ASAN "Enable AddressSanitizer, a fast memory error detector >> based on compiler instrumentation" OFF) >> if (ENABLE_ASAN) >> if (CMAKE_COMPILER_IS_GNUCC) >> >> =============== >> >> shouldn't it be message(FATAL_ERROR "...") ? So that cmake config fails. >> Otherwise it'll produce the warning, but proceed to build anyway. > Agree, replaced it to FATAL_ERROR. > > <snipped> > >> +if(ENABLE_FUZZER AND CMAKE_CXX_COMPILER_ID STREQUAL "Clang") >> + set(TestName "test_csv") >> ================= >> >> If you error on compiler check, as mentioned above, there's no need to >> check for compiler here. It's the only place left, besides. You've omitted the >> checks in http_parser and uri tests. > Just forgot to remove it. Fixed in a branch. Hi, Sergey. Thanks for the fixes! LGTM. > > <snipped> -- -- Serge Petrenko
next prev parent reply other threads:[~2020-04-30 13:01 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-20 8:47 Sergey Bronnikov 2020-04-24 13:56 ` Serge Petrenko 2020-04-29 9:28 ` Sergey Bronnikov 2020-04-30 11:10 ` Serge Petrenko 2020-04-30 11:40 ` Sergey Bronnikov 2020-04-30 13:01 ` Serge Petrenko [this message] 2020-04-28 11:19 ` Igor Munkin 2020-04-29 12:09 ` Sergey Bronnikov 2020-05-26 15:54 ` Igor Munkin 2020-12-01 16:22 ` Sergey Bronnikov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=38eb3f58-becb-cdc4-99f4-1eac40c78491@tarantool.org \ --to=sergepetrenko@tarantool.org \ --cc=o.piskunov@tarantool.org \ --cc=sergeyb@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2] Add infrastructure for fuzzing testing and fuzzers' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox