From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id EC5C74696C3
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 30 Apr 2020 16:01:19 +0300 (MSK)
References: <33ba1d50585e101aa025d899116c48d56be59202.1587372354.git.sergeyb@tarantool.org>
 <7A9E4292-A080-46A7-AFF2-084AD61A51EC@tarantool.org>
 <20200429092855.GA83580@pony.bronevichok.ru>
 <d083dbe1-c1ce-c306-edb4-17e0ed6bf6de@tarantool.org>
 <20200430114020.GD12330@pony.bronevichok.ru>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <38eb3f58-becb-cdc4-99f4-1eac40c78491@tarantool.org>
Date: Thu, 30 Apr 2020 16:01:18 +0300
MIME-Version: 1.0
In-Reply-To: <20200430114020.GD12330@pony.bronevichok.ru>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: ru
Subject: Re: [Tarantool-patches] [PATCH v2] Add infrastructure for fuzzing
 testing and fuzzers
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: o.piskunov@tarantool.org, tml <tarantool-patches@dev.tarantool.org>


30.04.2020 14:40, Sergey Bronnikov wrote:
> Hi, Serge
>
> On 14:10 Thu 30 Apr , Serge Petrenko wrote:
>> diff --git a/cmake/profile.cmake b/cmake/profile.cmake
>> index bc4bf67f5..419f7b3cc 100644
>> --- a/cmake/profile.cmake
>> +++ b/cmake/profile.cmake
>> @@ -42,6 +42,15 @@ else()
>>       add_definitions(-DNVALGRIND=1)
>>   endif()
>>
>> +option(ENABLE_FUZZER "Enable fuzzing testing" OFF)
>> +if(ENABLE_FUZZER)
>> +    if(NOT (CMAKE_C_COMPILER_ID STREQUAL "Clang"))
>> +        message(WARNING "Fuzzing supported with Clang compiler only.")
>> +    else()
>> +        set(TESTING_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/Testing")
>> +    endif()
>> +endif()
>> +
>>   option(ENABLE_ASAN "Enable AddressSanitizer, a fast memory error detector
>> based on compiler instrumentation" OFF)
>>   if (ENABLE_ASAN)
>>       if (CMAKE_COMPILER_IS_GNUCC)
>>
>> ===============
>>
>> shouldn't it be message(FATAL_ERROR "...") ?  So  that cmake config fails.
>> Otherwise it'll produce the warning, but proceed  to build anyway.
> Agree, replaced it to FATAL_ERROR.
>
> <snipped>
>
>> +if(ENABLE_FUZZER AND CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
>> +    set(TestName "test_csv")
>> =================
>>
>> If you error on compiler check, as  mentioned above, there's no need to
>> check for compiler here. It's the only  place left, besides. You've omitted the
>> checks in http_parser and uri  tests.
> Just forgot to remove it. Fixed in a branch.


Hi, Sergey. Thanks for the fixes! LGTM.

>
> <snipped>

-- 
--
Serge Petrenko