Re: [Tarantool-patches] [PATCH v6 0/2] fiber: Handle stack madvise/mprotect errors

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Hi! Thanks for the patchset!

On 06/02/2020 13:31, Cyrill Gorcunov wrote:
> Sasha, I put your reviewed-by tag, please let me know if
> you're not agreed.
> 
> Vlad, take a look please once time permit.
> 
> v6 (by @alexander.turenko):
>  - polish unit test (style and results)
>  - fix bracing in core/fiber.c
> 
> issue https://github.com/tarantool/tarantool/issues/4722
> branch gorcunov/gh-4722-mprotect-diag-error-6

Could you please put a link at the branch next time? Usually
link is very useful when you can just click and look whether
CI is ok.

> Cyrill Gorcunov (2):
>   fiber: set diagnostics at madvise/mprotect failure
>   fiber: leak slab if unable to bring prots back
> 
>  src/lib/core/errinj.h        |   2 +
>  src/lib/core/fiber.c         |  93 +++++++++++++++++++-----
>  test/box/errinj.result       | 136 ++++++++++++++++++-----------------
>  test/unit/CMakeLists.txt     |   4 ++
>  test/unit/fiber_stack.cc     |  83 +++++++++++++++++++++
>  test/unit/fiber_stack.result |   7 ++
>  test/unit/suite.ini          |   2 +-
>  7 files changed, 242 insertions(+), 85 deletions(-)
>  create mode 100644 test/unit/fiber_stack.cc
>  create mode 100644 test/unit/fiber_stack.result
>