From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 1/1] iproto: don't destroy a session during disconnect
Date: Sun, 17 Nov 2019 21:33:22 +0100 [thread overview]
Message-ID: <383aa58a-36e4-231a-44a4-f497a3a6a47e@tarantool.org> (raw)
In-Reply-To: <20191117174948.GC2498@atlas>
Ok, will do tomorrow. Kirill, please, don't push anything.
On 17/11/2019 18:49, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/11/17 20:44]:
>> But I could replace both flags with a 'state':
>> IPROTO_CON_ALIVE -> IPROTO_CON_CLOSED -> IPROTO_CON_PENDING_DESTROY,
>> IPROTO_CON_DESTROYED.
>>
>> Alive is an initial state. Closed is when the socket dies and
>> disconnect is sent to TX. Pending destroy is an optional state,
>> equivalent of do_destroy_on_close. Destroyed is an equivalent of
>> is_destroy_sent.
>>
>> If you think this is better, I can do that.
>>
>
> I think it's better.
>
>
prev parent reply other threads:[~2019-11-17 20:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-16 0:35 Vladislav Shpilevoy
2019-11-16 13:07 ` Konstantin Osipov
2019-11-17 17:47 ` Vladislav Shpilevoy
2019-11-17 17:49 ` Konstantin Osipov
2019-11-17 20:33 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=383aa58a-36e4-231a-44a4-f497a3a6a47e@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/1] iproto: don'\''t destroy a session during disconnect' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox