From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v3 02/10] sql: fix leak on CREATE TABLE and resolve self ref
Date: Fri, 15 Jun 2018 01:46:57 +0300 [thread overview]
Message-ID: <3833E5C5-1D99-442A-B0FC-101EC24E9FD7@tarantool.org> (raw)
In-Reply-To: <ffde2ee57cfc53235492409d791bcf611b685b11.1528997527.git.kshcherbatov@tarantool.org>
Nitpicking: if you can’t fit commit subject into 50 chars,
you are able to shrink it and instead write about it in commit message.
Like:
sql: fix memory leaks
This patch fixes several memory leaks. One of them appeared during
introducing space_def in struct Table. Name of table wasn’t released
in case of successful returning from function sqlite3StartTable().
Second one - bla-bla-bla.
It is only advise, tho. But I stick to the point that describing provided changes
aren’t less important then code itself.
Patch itself looks OK to me.
next prev parent reply other threads:[~2018-06-14 22:46 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 17:32 [tarantool-patches] [PATCH v3 00/10] sql: remove Triggers to server Kirill Shcherbatov
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 01/10] box: move db->pShchema init to sql_init Kirill Shcherbatov
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 10/10] sql: VDBE tests for trigger existence Kirill Shcherbatov
2018-06-14 19:27 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-15 16:21 ` Kirill Shcherbatov
2018-06-18 15:42 ` Vladislav Shpilevoy
2018-06-18 19:22 ` Kirill Shcherbatov
2018-06-19 10:24 ` Vladislav Shpilevoy
2018-06-19 15:12 ` Kirill Shcherbatov
2018-06-19 15:23 ` Vladislav Shpilevoy
2018-06-20 6:38 ` Kirill Shcherbatov
2018-06-20 8:10 ` Vladislav Shpilevoy
2018-06-20 8:24 ` Kirill Shcherbatov
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 02/10] sql: fix leak on CREATE TABLE and resolve self ref Kirill Shcherbatov
2018-06-14 22:46 ` n.pettik [this message]
2018-06-15 9:25 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 03/10] sql: fix sql len in tarantoolSqlite3RenameTrigger Kirill Shcherbatov
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 04/10] box: port schema_find_id to C Kirill Shcherbatov
2018-06-14 19:27 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-14 22:46 ` n.pettik
2018-06-15 9:25 ` Vladislav Shpilevoy
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 05/10] sql: refactor sql_expr_compile to return AST Kirill Shcherbatov
2018-06-14 19:27 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-15 16:21 ` Kirill Shcherbatov
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 06/10] sql: move sqlite3DeleteTrigger to sql.h Kirill Shcherbatov
2018-06-14 19:27 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 07/10] box: sort error codes in misc.test Kirill Shcherbatov
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 08/10] sql: new _trigger space format with space_id Kirill Shcherbatov
2018-06-14 19:27 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-15 16:21 ` Kirill Shcherbatov
2018-06-14 17:32 ` [tarantool-patches] [PATCH v3 09/10] sql: move Triggers to server Kirill Shcherbatov
2018-06-14 19:27 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-15 16:21 ` Kirill Shcherbatov
2018-06-18 15:42 ` Vladislav Shpilevoy
2018-06-18 19:22 ` Kirill Shcherbatov
2018-06-14 17:34 ` [tarantool-patches] Re: [PATCH v3 00/10] sql: remove " Kirill Shcherbatov
2018-06-20 8:35 ` Vladislav Shpilevoy
2018-06-28 15:47 ` n.pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3833E5C5-1D99-442A-B0FC-101EC24E9FD7@tarantool.org \
--to=korablev@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v3 02/10] sql: fix leak on CREATE TABLE and resolve self ref' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox