Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov <sergeyb@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
	tarantool-patches@dev.tarantool.org, lvasiliev@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v7 2/3] luacheck: fix warnings in test/app
Date: Mon, 21 Dec 2020 14:00:34 +0300	[thread overview]
Message-ID: <380b691d-7ece-e672-3b4b-e294e799f29b@tarantool.org> (raw)
In-Reply-To: <4d0f40dd-3974-54d0-4986-f210774dc984@tarantool.org>

Hi! Thanks for review!

On 20.12.2020 16:59, Vladislav Shpilevoy wrote:
> Thanks for the patch!
>
>> diff --git a/.luacheckrc b/.luacheckrc
>> index ae96576ec..d9093a5eb 100644
>> --- a/.luacheckrc
>> +++ b/.luacheckrc
>> @@ -109,3 +109,6 @@ files["test/app-tap/lua/require_mod.lua"] = {
>>   files["test/app-tap/string.test.lua"] = {
>>       globals = {"utf8"}
>>   }
>> +files["test/app/lua/fiber.lua"] = {
>> +    globals = {"box_fiber_run_test"}
>> +}
> fiber.lua is used in one place, where it can be properly fixed
> instead of ignored. fiber.lua can 'return box_fiber_run_test' in
> the end instead of passing this function as a global variable.
Fixed in a branch and force-pushed.

--- a/test/app/fiber.result
+++ b/test/app/fiber.result
@@ -560,11 +560,11 @@ space:drop()
  ---
  ...
  -- box.fiber test (create, resume, yield, status)
-dofile("fiber.lua")
+f = dofile("fiber.lua")
  ---
  ...
  -- print run fiber's test
-box_fiber_run_test()
+f()
  ---
  - - 'A: odd  1'
    - 'tester: status(printer) = suspended'

--- a/test/app/fiber.test.lua
+++ b/test/app/fiber.test.lua
@@ -215,9 +215,9 @@ fiber.self():name(old_name)
  space:drop()

  -- box.fiber test (create, resume, yield, status)
-dofile("fiber.lua")
+f = dofile("fiber.lua")
  -- print run fiber's test
-box_fiber_run_test()
+f()
  -- various...
  function testfun() while true do fiber.sleep(10) end end
  f = fiber.create(testfun)
diff --git a/test/app/lua/fiber.lua b/test/app/lua/fiber.lua
index 64977623e..301b0f098 100644
--- a/test/app/lua/fiber.lua
+++ b/test/app/lua/fiber.lua
@@ -78,3 +78,5 @@ function box_fiber_run_test()
      end
         return result
  end
+
+return box_fiber_run_test

  reply	other threads:[~2020-12-21 11:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16 15:59 [Tarantool-patches] [PATCH v7 0/3] Fix luacheck warnings in test/app-tap and test/app sergeyb
2020-12-16 16:00 ` [Tarantool-patches] [PATCH v7 1/3] luacheck: fix warnings in test/app-tap sergeyb
2020-12-20 13:59   ` Vladislav Shpilevoy
2020-12-21 10:02     ` Sergey Bronnikov
2020-12-16 16:00 ` [Tarantool-patches] [PATCH v7 2/3] luacheck: fix warnings in test/app sergeyb
2020-12-20 13:59   ` Vladislav Shpilevoy
2020-12-21 11:00     ` Sergey Bronnikov [this message]
2020-12-16 16:00 ` [Tarantool-patches] [PATCH v7 3/3] luacheck: remove unneeded comment sergeyb
2020-12-21 17:17 ` [Tarantool-patches] [PATCH v7 0/3] Fix luacheck warnings in test/app-tap and test/app Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=380b691d-7ece-e672-3b4b-e294e799f29b@tarantool.org \
    --to=sergeyb@tarantool.org \
    --cc=lvasiliev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v7 2/3] luacheck: fix warnings in test/app' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox