From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org
Cc: alexander.turenko@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] lua: show error on attempt to access to tuple of unsupported type
Date: Wed, 3 Jun 2020 23:47:56 +0200 [thread overview]
Message-ID: <37b51022-92fe-605f-2335-a1e6c77d9584@tarantool.org> (raw)
In-Reply-To: <bfc94d4a08072088c00c4eafa7da6db42ec2736b.1589812024.git.sergeyb@tarantool.org>
Hi!
I dove into the issue context, and from what I see, this
commit does not fix anything.
The issue is much deeper that just msgpackffi decoder problem.
Moreover, you said it is 'fixed' for 1.10, but the problem
exists not only on 1.10. It is a general problem of any version
interacting with any newer version.
Besides, I see Alexander Tu. provided lots of comments, which
you didn't address. So please, proceed with fixing his comments
first.
In my opinion, we should hide spaces with unknown fields. I.e.
whose tuple_format object couldn't be created on the client side.
It looks like the simplest option. The client anyway can't do
anything useful with these spaces.
prev parent reply other threads:[~2020-06-03 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 14:27 sergeyb
2020-05-23 4:14 ` Alexander Turenko
2020-06-02 9:34 ` Sergey Bronnikov
2020-06-03 21:47 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37b51022-92fe-605f-2335-a1e6c77d9584@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] lua: show error on attempt to access to tuple of unsupported type' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox