From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Chris Sosnin <k.sosnin@tarantool.org>,
tarantool-patches@dev.tarantool.org, sergepetrenko@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 0/2] decNumber utilites for SQL
Date: Thu, 25 Jun 2020 23:04:25 +0200 [thread overview]
Message-ID: <36d468de-52a7-c7dc-b858-3b4c25301769@tarantool.org> (raw)
In-Reply-To: <cover.1593017012.git.k.sosnin@tarantool.org>
LGTM. But better add tests and a wrapper for decNumberIsInt()
in the tarantool/tarantool's patch.
next prev parent reply other threads:[~2020-06-25 21:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 16:53 Chris Sosnin
2020-06-24 16:53 ` [Tarantool-patches] [PATCH v2 1/2] Refactor decNumberFromString Chris Sosnin
2020-06-24 22:22 ` Vladislav Shpilevoy
2020-06-25 14:21 ` Chris Sosnin
2020-06-24 16:53 ` [Tarantool-patches] [PATCH v2 2/2] Add IsInt method for checking the fractional part of a number Chris Sosnin
2020-06-24 22:23 ` Vladislav Shpilevoy
2020-06-25 14:22 ` Chris Sosnin
2020-06-25 21:04 ` Vladislav Shpilevoy [this message]
2020-06-26 10:57 ` [Tarantool-patches] [PATCH v2 0/2] decNumber utilites for SQL Serge Petrenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36d468de-52a7-c7dc-b858-3b4c25301769@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=k.sosnin@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 0/2] decNumber utilites for SQL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox