From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <max.kokryashkin@gmail.com>,
tarantool-patches@dev.tarantool.org, skaplun@tarantool.org,
imun@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] debug: generalized extension
Date: Wed, 4 Oct 2023 12:01:22 +0300 [thread overview]
Message-ID: <36d3cdb5-36d4-45a2-aea4-57f44e5ce183@tarantool.org> (raw)
In-Reply-To: <20230918142642.76199-1-m.kokryashkin@tarantool.org>
Hi, Max
On 9/18/23 17:26, Maxim Kokryashkin wrote:
> This patch joins the LLDB and GDB LuaJIT debugging extensions
> into one, so now the extension logic can be debugger-agnostic.
> To do that, an adapter class is introduced, and all of the
> debugger-specific behavior is encapsulated there. The extension
> auto-detects the debugger it was loaded into and selects the
> correct low-level logic implementation.
> ---
> Branch: https://github.com/tarantool/luajit/tree/fckxorg/generalized-debugger
> src/luajit-gdb.py | 885 --------------------------
> src/{luajit_lldb.py => luajit_dbg.py} | 617 ++++++++++++------
> 2 files changed, 417 insertions(+), 1085 deletions(-)
There is a diff with 2k lines. How does one can make sure that there are
no regressions after refactoring?
<snipped>
prev parent reply other threads:[~2023-10-04 9:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 14:26 Maxim Kokryashkin via Tarantool-patches
2023-10-04 9:01 ` Sergey Bronnikov via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36d3cdb5-36d4-45a2-aea4-57f44e5ce183@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] debug: generalized extension' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox