From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>,
Sergey Bronnikov <estetus@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 6/8][v3] ci: add workflow with disabled profilers
Date: Mon, 24 Feb 2025 21:16:24 +0300 [thread overview]
Message-ID: <36831d73-c4db-45c0-91d7-29a8a662812e@tarantool.org> (raw)
In-Reply-To: <Z7xAblTG6TzFpf3-@root>
[-- Attachment #1: Type: text/plain, Size: 765 bytes --]
Hi, Sergey,
thanks for review!
On 24.02.2025 12:48, Sergey Kaplun via Tarantool-patches wrote:
> Hi, Sergey!
> Thanks for the fixes.
> LGTM, after fixing a nit regarding the commit message below.
>
> Minor: Please provide a minor sentence that mentions that this workflow
> runs our test suite with both profilers (memprof and sysprof) disabled.
Updated version:
Author: Sergey Bronnikov <sergeyb@tarantool.org>
Date: Tue Feb 18 17:08:17 2025 +0300
ci: add workflow with disabled profilers
The patch adds a workflow that runs our test suite with both
profilers (memprof and sysprof) disabled.
Needed for the following commit.
> On 20.02.25, Sergey Bronnikov wrote:
>> Needed for the following commit.
>> ---
> <snipped>
>
[-- Attachment #2: Type: text/html, Size: 1664 bytes --]
next prev parent reply other threads:[~2025-02-24 18:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 11:21 [Tarantool-patches] [PATCH luajit 0/8][v3] Fix profilers issues Sergey Bronnikov via Tarantool-patches
2025-02-20 11:21 ` [Tarantool-patches] [PATCH luajit 1/8][v3] test: add descriptions to sysprof testcases Sergey Bronnikov via Tarantool-patches
2025-02-24 11:15 ` Sergey Kaplun via Tarantool-patches
2025-02-20 11:21 ` [Tarantool-patches] [PATCH luajit 2/8][v3] test: align test title with test filename Sergey Bronnikov via Tarantool-patches
2025-02-24 9:40 ` Sergey Kaplun via Tarantool-patches
2025-02-24 15:27 ` Sergey Bronnikov via Tarantool-patches
2025-02-20 11:21 ` [Tarantool-patches] [PATCH luajit 3/8][v3] sysprof: fix typo in the comment Sergey Bronnikov via Tarantool-patches
2025-02-24 11:15 ` Sergey Kaplun via Tarantool-patches
2025-02-20 11:21 ` [Tarantool-patches] [PATCH luajit 4/8][v3] sysprof: introduce specific errors and default mode Sergey Bronnikov via Tarantool-patches
2025-02-24 12:46 ` Sergey Kaplun via Tarantool-patches
2025-02-24 18:05 ` Sergey Bronnikov via Tarantool-patches
2025-03-05 7:55 ` Sergey Kaplun via Tarantool-patches
2025-03-05 10:48 ` Sergey Bronnikov via Tarantool-patches
2025-03-05 14:48 ` Sergey Bronnikov via Tarantool-patches
2025-03-05 15:17 ` Sergey Kaplun via Tarantool-patches
2025-02-20 11:21 ` [Tarantool-patches] [PATCH luajit 5/8][v3] test: introduce flag LUAJIT_DISABLE_MEMPROF Sergey Bronnikov via Tarantool-patches
2025-02-24 9:45 ` Sergey Kaplun via Tarantool-patches
2025-02-24 18:06 ` Sergey Bronnikov via Tarantool-patches
2025-02-20 11:21 ` [Tarantool-patches] [PATCH luajit 6/8][v3] ci: add workflow with disabled profilers Sergey Bronnikov via Tarantool-patches
2025-02-24 9:48 ` Sergey Kaplun via Tarantool-patches
2025-02-24 18:16 ` Sergey Bronnikov via Tarantool-patches [this message]
2025-02-20 11:21 ` [Tarantool-patches] [PATCH luajit 7/8][v3] misc: specific message for " Sergey Bronnikov via Tarantool-patches
2025-02-24 11:28 ` Sergey Kaplun via Tarantool-patches
2025-02-24 18:37 ` Sergey Bronnikov via Tarantool-patches
2025-03-05 8:24 ` Sergey Kaplun via Tarantool-patches
2025-02-20 11:21 ` [Tarantool-patches] [PATCH luajit 8/8][v3] memprof: set default path to profiling output file Sergey Bronnikov via Tarantool-patches
2025-02-24 11:14 ` Sergey Kaplun via Tarantool-patches
2025-02-24 18:40 ` Sergey Bronnikov via Tarantool-patches
2025-03-05 10:57 ` Sergey Kaplun via Tarantool-patches
2025-03-05 14:29 ` Sergey Bronnikov via Tarantool-patches
2025-03-05 15:12 ` Sergey Kaplun via Tarantool-patches
2025-03-06 6:01 ` Sergey Bronnikov via Tarantool-patches
2025-03-12 11:11 ` [Tarantool-patches] [PATCH luajit 0/8][v3] Fix profilers issues Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36831d73-c4db-45c0-91d7-29a8a662812e@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=estetus@gmail.com \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 6/8][v3] ci: add workflow with disabled profilers' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox