From: Sergey Bronnikov <sergeyb@tarantool.org> To: Oleg Babin <olegrok@tarantool.org> Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Subject: Re: [Tarantool-patches] [PATCH] lua: introduce function for uuid comparison Date: Fri, 13 Nov 2020 09:37:45 +0300 [thread overview] Message-ID: <35fd8ac8-ed6d-c4e8-1d7a-e7b5b6685147@tarantool.org> (raw) In-Reply-To: <4523cd54-548c-11ee-90fc-5cf126e7ca2a@tarantool.org> Hi, Oleg On 12.11.2020 12:55, Oleg Babin wrote: > Hi, Sergey! > > The main reason is "uuid tests were implemented with diff-based approach". Got it. Missed it that you haven't add new test and just enhanced the old one. > > However I can easily convert my tests to TAP but I don't want touch > existing tests of course. > > Do you think we should start moving towards TAP-based approach for > "uuid" module testing? I think no. > On 12/11/2020 12:44, Sergey Bronnikov wrote: >> Hi, Oleg >> >> thanks for the patch! >> Looks like you expect a review from Leonid and Vlad, but I have a >> question regarding tests in the patch. >> >> On 23:04 Wed 11 Nov , olegrok@tarantool.org wrote: >>> --- a/test/app/uuid.result >>> +++ b/test/app/uuid.result >> For Tarantool core we have two kind of tests: with diff-based approach >> and TAP based tests. Your tests can be easily implemented with a TAP >> approach, when test data and oracle are in the code. But you preferred a >> diff-based approach here. Why?
next prev parent reply other threads:[~2020-11-13 6:37 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-11 20:04 olegrok 2020-11-12 9:44 ` Sergey Bronnikov 2020-11-12 9:55 ` Oleg Babin 2020-11-13 6:37 ` Sergey Bronnikov [this message] 2020-11-16 21:36 ` Vladislav Shpilevoy 2020-11-17 9:11 ` Igor Munkin 2020-11-17 22:08 ` Vladislav Shpilevoy 2020-11-18 8:02 ` Oleg Babin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=35fd8ac8-ed6d-c4e8-1d7a-e7b5b6685147@tarantool.org \ --to=sergeyb@tarantool.org \ --cc=olegrok@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] lua: introduce function for uuid comparison' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox