Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov <sergeyb@tarantool.org>
To: olegrok@tarantool.org
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] lua: introduce function for uuid comparison
Date: Thu, 12 Nov 2020 12:44:06 +0300	[thread overview]
Message-ID: <20201112094406.GA76747@pony.bronevichok.ru> (raw)
In-Reply-To: <20201111200408.49148-1-olegrok@tarantool.org>

Hi, Oleg

thanks for the patch!
Looks like you expect a review from Leonid and Vlad, but I have a
question regarding tests in the patch.

On 23:04 Wed 11 Nov , olegrok@tarantool.org wrote:
> --- a/test/app/uuid.result
> +++ b/test/app/uuid.result

For Tarantool core we have two kind of tests: with diff-based approach
and TAP based tests. Your tests can be easily implemented with a TAP
approach, when test data and oracle are in the code. But you preferred a
diff-based approach here. Why?

  reply	other threads:[~2020-11-12  9:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-11 20:04 olegrok
2020-11-12  9:44 ` Sergey Bronnikov [this message]
2020-11-12  9:55   ` Oleg Babin
2020-11-13  6:37     ` Sergey Bronnikov
2020-11-16 21:36 ` Vladislav Shpilevoy
2020-11-17  9:11   ` Igor Munkin
2020-11-17 22:08     ` Vladislav Shpilevoy
2020-11-18  8:02   ` Oleg Babin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201112094406.GA76747@pony.bronevichok.ru \
    --to=sergeyb@tarantool.org \
    --cc=olegrok@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] lua: introduce function for uuid comparison' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox