From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/3] user: don't throw C++ exception from user_find_by_name
Date: Tue, 5 Nov 2019 12:44:13 +0300 [thread overview]
Message-ID: <35c3c2c3-ad09-8b89-60b2-45d2afaf0bf0@tarantool.org> (raw)
In-Reply-To: <20191104172233.GB29784@atlas>
On 04/11/2019 20:22, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/11/01 00:39]:
>> +-- Invalid user.
>> +session.su('does not exist')
>> +---
>> +- error: User 'does not exist' is not found
>> +...
>> +-- The point of this test is to try a name > max
>> +-- allowed name.
>> +session.su(string.rep('a', 66000))
>> +---
>> +- error: name length 66000 is greater than BOX_NAME_MAX
>> +...
>
> That's pretty strange, I think we had such tests before.
>
> Did you actually verify that the tests do not pass before your
> fix? Or they do pass because there is a catch clause somewhere
> up the stack anyway?
That test fails before my patch. The error was 'C++ exception'.
Now it is a ClientError object.
>
> Please clarify in the comment.
>
> Otherwise LGTM.
>
>
next prev parent reply other threads:[~2019-11-05 9:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 21:42 [Tarantool-patches] [PATCH 0/3] Credentials follow up Vladislav Shpilevoy
2019-10-31 21:42 ` [Tarantool-patches] [PATCH 1/3] test: fix flaky box/access_sysview.test.lua Vladislav Shpilevoy
2019-11-04 17:20 ` Konstantin Osipov
2019-10-31 21:42 ` [Tarantool-patches] [PATCH 2/3] user: don't throw C++ exception from user_find_by_name Vladislav Shpilevoy
2019-11-04 17:22 ` Konstantin Osipov
2019-11-05 9:44 ` Vladislav Shpilevoy [this message]
2019-10-31 21:42 ` [Tarantool-patches] [PATCH 3/3] session: su left dangling credentials object on stack Vladislav Shpilevoy
2019-11-04 17:23 ` Konstantin Osipov
2019-11-01 13:54 ` [Tarantool-patches] [PATCH 0/3] Credentials follow up Kirill Yukhin
2019-11-04 17:23 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35c3c2c3-ad09-8b89-60b2-45d2afaf0bf0@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/3] user: don'\''t throw C++ exception from user_find_by_name' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox