From: Roman Khabibov <roman.habibov@tarantool.org> To: Alexander Turenko <alexander.turenko@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [tarantool-patches] [server-dev] Re: Re: [PATCH v2 1/2] lua: return getaddrinfo() errors Date: Tue, 10 Dec 2019 19:25:11 +0300 [thread overview] Message-ID: <35E941DB-8252-478B-80C2-592FFAA6011E@tarantool.org> (raw) In-Reply-To: <20191208194800.b6oiyzy3zx23mv4h@tkn_work_nb> > On Dec 8, 2019, at 22:48, Alexander Turenko <alexander.turenko@tarantool.org> wrote: > > I didn't find where to comment args validation patch, so I'll comment it > here: > > It changes socket.connect() (part of Lua Socket API), but does not > change luasocket_master:connect() (part of Lua Socket API too) and > does not change socket.tcp_connect() (our native function). > > The same: socket.bind() (Lua Socket API) was changed, but > luasocket_master:bind() (Lua Socket API) was not. Our native > socket.tcp_server() was not changed too. > > That's all looks strange. Let's extract this patch and either drop it or > bring it to an acceptable state and send separately from this patchset. Dropped. > ---- > >>> `socket_object:connect` is not valid Lua syntax. It is better to write >>> it as socket_object:connect() or socket_object.connect. >>> >>> net.box API also was changed. >> >> net.box’s .connect() returns error as second return value. Now, it can return >> tcp_connect()’s errors (getaddrinfo). Don’t think, we should note this in the >> net.box doc. > > I see now, the API is not changed, only connection.error message. > >>>> Connect to a remote host using tcp_connect() within. If it is no >>>> error, return a socket object. >>> >>> It is hard to understood w/o a context. Please, either describe API >>> changes formally or give an example that will show the API change. >> In the commit message. > > See the comment below. > >>>> diff --git a/src/lua/socket.lua b/src/lua/socket.lua >>>> index a334ad45b..e4815adbb 100644 >>>> --- a/src/lua/socket.lua >>>> +++ b/src/lua/socket.lua >>>> @@ -1041,9 +1041,12 @@ local function tcp_connect(host, port, timeout) >>>> end >>>> local timeout = timeout or TIMEOUT_INFINITY >>>> local stop = fiber.clock() + timeout >>>> - local dns = getaddrinfo(host, port, timeout, { type = 'SOCK_STREAM', >>>> + local dns, err = getaddrinfo(host, port, timeout, { type = 'SOCK_STREAM', >>>> protocol = 'tcp' }) >>>> - if dns == nil or #dns == 0 then >>>> + if dns == nil then >>>> + return nil, err >>>> + end >>>> + if #dns == 0 then >>>> boxerrno(boxerrno.EINVAL) >>>> return nil >>>> end >>> >>> Cited to link from below. >>> >>>> @@ -1360,9 +1363,16 @@ local function lsocket_tcp_connect(self, host, port) >>>> -- This function is broken by design >>>> local ga_opts = { family = 'AF_INET', type = 'SOCK_STREAM' } >>>> local timeout = deadline - fiber.clock() >>>> - local dns = getaddrinfo(host, port, timeout, ga_opts) >>>> + local dns, err = getaddrinfo(host, port, timeout, ga_opts) >>>> if dns == nil or #dns == 0 then >>>> - self._errno = boxerrno.EINVAL >>>> + return nil, err >>>> + end >>>> + if dns == nil then >>>> + boxerrno(self._errno) >>>> + return nil, err >>>> + end >>>> + if #dns == 0 then >>>> + boxerrno(self._errno) >>>> return nil, socket_error(self) >>>> end >>> >>> We'll never reach the last two if's bodies. However the similar fragment >>> above in tcp_connect() was changed in the right way. >> >> @@ -1360,9 +1363,12 @@ local function lsocket_tcp_connect(self, host, port) >> -- This function is broken by design >> local ga_opts = { family = 'AF_INET', type = 'SOCK_STREAM' } >> local timeout = deadline - fiber.clock() >> - local dns = getaddrinfo(host, port, timeout, ga_opts) >> - if dns == nil or #dns == 0 then >> - self._errno = boxerrno.EINVAL >> + local dns, err = getaddrinfo(host, port, timeout, ga_opts) >> + if dns == nil then >> + return nil, err >> + end >> + if #dns == 0 then >> + boxerrno(self._errno) >> return nil, socket_error(self) >> end >> for _, remote in ipairs(dns) do > > EINVAL here is changed to self._errno, which is always `nil` at least > for typical usage of lua socket: `s = socket.tcp()`, then `s:connect()`. > > Let's keep the old behaviour (EINVAL) when getaddrinfo() returns zero > amount of addresses. > > RFC 2553 ('Basic Socket Interface Extensions for IPv6') states: > > | Upon successful return a pointer to a linked list of one or more > | addrinfo structures is returned through the final argument. > > RFC 3493 ('Basic Socket Interface Extensions for IPv6') states the same, > but more explicitly: > > | Upon successful return of getaddrinfo(), the location to which res > | points shall refer to a linked list of addrinfo structures, each of > | which shall specify a socket address and information for use in > | creating a socket with which to use that socket address. The list > | shall include at least one addrinfo structure. > > So this situation should not occur. But anyway we should not miss to set > a certain errno in the case at least for consistency with tcp_connect(). > > Also I think that we should set errno to EINVAL when getaddrinfo() fails > to keep the code backward compatible: say, a user lean on this value > when tcp_connect() / :connect() returns `nil`. I understand so: diff --git a/src/lua/socket.lua b/src/lua/socket.lua index a334ad45b..6c829a11c 100644 --- a/src/lua/socket.lua +++ b/src/lua/socket.lua @@ -995,7 +995,13 @@ local function getaddrinfo(host, port, timeout, opts) end end - return internal.getaddrinfo(host, port, timeout, ga_opts) + + local ret, err = internal.getaddrinfo(host, port, timeout, ga_opts) + if ret == nil then + boxerrno(boxerrno.EINVAL) + return nil, err + end + return ret end -- tcp connector @@ -1041,9 +1047,12 @@ local function tcp_connect(host, port, timeout) end local timeout = timeout or TIMEOUT_INFINITY local stop = fiber.clock() + timeout - local dns = getaddrinfo(host, port, timeout, { type = 'SOCK_STREAM', + local dns, err = getaddrinfo(host, port, timeout, { type = 'SOCK_STREAM', protocol = 'tcp' }) - if dns == nil or #dns == 0 then + if dns == nil then + return nil, err + end + if #dns == 0 then boxerrno(boxerrno.EINVAL) return nil end @@ -1360,8 +1369,12 @@ local function lsocket_tcp_connect(self, host, port) -- This function is broken by design local ga_opts = { family = 'AF_INET', type = 'SOCK_STREAM' } local timeout = deadline - fiber.clock() - local dns = getaddrinfo(host, port, timeout, ga_opts) - if dns == nil or #dns == 0 then + local dns, err = getaddrinfo(host, port, timeout, ga_opts) + if dns == nil then + self._errno = boxerrno() + return nil, err + end + if #dns == 0 then self._errno = boxerrno.EINVAL return nil, socket_error(self) end @@ -1547,9 +1560,12 @@ local function lsocket_connect(host, port) if host == nil or port == nil then error("Usage: luasocket.connect(host, port)") end - local s = tcp_connect(host, port) + local s, err = tcp_connect(host, port) if not s then - return nil, boxerrno.strerror() + if not err then + return nil, boxerrno.strerror() + end + return nil, err end setmetatable(s, lsocket_tcp_client_mt) return s >> commit b3a8af5c605db811deb40946cfbcf9dcd45ad75c >> Author: Roman Khabibov <roman.habibov@tarantool.org> >> Date: Thu Nov 21 14:37:54 2019 +0300 >> >> lua: return getaddrinfo() errors >> >> Add getaddrinfo() errors into the several fuctions of socket. Now >> getaddrinfo() can return a pair of values (nil and error message) >> in case of error. >> >> Closes #4138 >> >> @TarantoolBot document >> Title: socket API changes >> >> * socket.getaddrinfo() >> >> Can return error message as second return value in case of >> internal getaddrinfo() error. >> >> Example: >> tarantool> socket.getaddrinfo('non_exists_hostname', 3301) >> --- >> - null >> - 'getaddrinfo: nodename nor servname provided, or not known' >> ... >> >> * socket.tcp_connect() >> >> Can return socket.getaddrinfo() error message as second return >> value. >> >> Example: >> tarantool> socket.tcp_connect('non_exists_hostname', 3301) >> --- >> - null >> - 'getaddrinfo: nodename nor servname provided, or not known' >> ... >> >> * socket_object:connect() >> >> Wrapper for the socket.tcp_connect() with arguments format >> checking. If it is no error, return a socket object. If it is not, >> return nil and error message (socket.tcp_connect() just returns >> nil in case of error except when it is an internal getaddrinfo() >> error). > > socket_object:connect() is part of Lua Socket API, so I would name the > instance 'luasocket_master': this would follow Lua Socket terminology: > http://w3.impa.br/~diego/software/luasocket/tcp.html > > We end with the situation that Lua Socket function checks its args, > but our one does not. This looks strange. > > Describing this function whose primary reason is to verify arguments is > not correct too. This function exists for compatibility with Lua Socket > API. > > The behaviour change here is that luasocket_master:connect() returns an > error from getaddrinfo() in the case rather than 'Invalid argument' as > it was before the commit. So the API is not changed and we can remove > this function from the docbot request (the same situation as in > net.box). lua: return getaddrinfo() errors Add getaddrinfo() errors into the several fuctions of socket. Now getaddrinfo() can return a pair of values (nil and error message) in case of error. Closes #4138 @TarantoolBot document Title: socket API changes * socket.getaddrinfo() Can return error message as second return value in case of internal getaddrinfo() error. Example: tarantool> socket.getaddrinfo('non_exists_hostname', 3301) --- - null - 'getaddrinfo: nodename nor servname provided, or not known' ... * socket.tcp_connect() Can return socket.getaddrinfo() error message as second return value. Example: tarantool> socket.tcp_connect('non_exists_hostname', 3301) --- - null - 'getaddrinfo: nodename nor servname provided, or not known' … > Also I see that we don't document Lua Socket part of the API: > https://www.tarantool.io/en/doc/1.10/reference/reference_lua/socket/ Is this the part of this patchset? Maybe, it would be better to do doc request separately. >> diff --git a/test/app/socket.test.lua b/test/app/socket.test.lua >> index 022cd4f40..9e66d6a8b 100644 >> --- a/test/app/socket.test.lua >> +++ b/test/app/socket.test.lua >> <...> >> @@ -968,6 +976,26 @@ socket.bind('127.0.0.1', 3301, '1') >> >> test_run:cmd("clear filter") >> >> +-- gh-4138 Check getaddrinfo() error from socket:connect() only. >> +-- Error code and error message returned by getaddrinfo() depends >> +-- on system's gai_strerror(). >> +test_run:cmd("setopt delimiter ';'") >> +function check_err(err) >> + if err == 'getaddrinfo: nodename nor servname provided, or not known' or >> + err == 'getaddrinfo: Servname not supported for ai_socktype' or >> + err == 'getaddrinfo: Name or service not known' then >> + return true >> + end >> + return false >> +end; >> +test_run:cmd("setopt delimiter ''"); >> + >> +s, err = socket.getaddrinfo('non_exists_hostname', 3301) >> +check_err(err) >> +s, err = socket.connect('non_exists_hostname', 3301) >> +check_err(err) > > Okay, we have the test case for Lua Socket API's socket.connect(). Let's > add a case for our native socket.tcp_connect(). +-- gh-4138 Check getaddrinfo() error from socket:connect() only. +-- Error code and error message returned by getaddrinfo() depends +-- on system's gai_strerror(). +test_run:cmd("setopt delimiter ';'") +function check_err(err) + if err == 'getaddrinfo: nodename nor servname provided, or not known' or + err == 'getaddrinfo: Servname not supported for ai_socktype' or + err == 'getaddrinfo: Name or service not known' then + return true + end + return false +end; +test_run:cmd("setopt delimiter ''"); + +s, err = socket.getaddrinfo('non_exists_hostname', 3301) +check_err(err) +s, err = socket.connect('non_exists_hostname', 3301) +check_err(err) +s, err = socket.tcp_connect('non_exists_hostname', 3301) +check_err(err) + commit d328fbf453248193d1a7c1406a3155f6b86b22c5 Author: Roman Khabibov <roman.habibov@tarantool.org> Date: Thu Nov 21 14:37:54 2019 +0300 lua: return getaddrinfo() errors Add getaddrinfo() errors into the several fuctions of socket. Now getaddrinfo() can return a pair of values (nil and error message) in case of error. Closes #4138 @TarantoolBot document Title: socket API changes * socket.getaddrinfo() Can return error message as second return value in case of internal getaddrinfo() error. Example: tarantool> socket.getaddrinfo('non_exists_hostname', 3301) --- - null - 'getaddrinfo: nodename nor servname provided, or not known' ... * socket.tcp_connect() Can return socket.getaddrinfo() error message as second return value. Example: tarantool> socket.tcp_connect('non_exists_hostname', 3301) --- - null - 'getaddrinfo: nodename nor servname provided, or not known' ... diff --git a/src/box/lua/net_box.lua b/src/box/lua/net_box.lua index c2e1bb9c4..2fb3e6df6 100644 --- a/src/box/lua/net_box.lua +++ b/src/box/lua/net_box.lua @@ -150,9 +150,12 @@ local function next_id(id) return band(id + 1, 0x7FFFFFFF) end local function establish_connection(host, port, timeout) local timeout = timeout or DEFAULT_CONNECT_TIMEOUT local begin = fiber.clock() - local s = socket.tcp_connect(host, port, timeout) + local s, err = socket.tcp_connect(host, port, timeout) if not s then - return nil, errno.strerror(errno()) + if not err then + return nil, errno.strerror(errno()) + end + return nil, err end local msg = s:read({chunk = IPROTO_GREETING_SIZE}, timeout - (fiber.clock() - begin)) diff --git a/src/lua/socket.c b/src/lua/socket.c index 130378caf..dbade2d27 100644 --- a/src/lua/socket.c +++ b/src/lua/socket.c @@ -774,6 +774,18 @@ lbox_getaddrinfo_result_wrapper(struct lua_State *L) return 1; } +/** + * Wrap coio_getaddrinfo() and call it. Push returned values onto + * @a L Lua stack. + * + * @param L Lua stack. + * + * @retval 1 Number of returned values by Lua function if + * coio_getaddrinfo() success. + * @retval 2 Number of returned values by Lua function if + * coio_getaddrinfo() is failed (first is nil, second is error + * message). + */ static int lbox_socket_getaddrinfo(struct lua_State *L) { @@ -816,7 +828,9 @@ lbox_socket_getaddrinfo(struct lua_State *L) if (dns_res != 0) { lua_pushnil(L); - return 1; + struct error *err = diag_get()->last; + lua_pushstring(L, err->errmsg); + return 2; } /* no results */ diff --git a/src/lua/socket.lua b/src/lua/socket.lua index a334ad45b..6c829a11c 100644 --- a/src/lua/socket.lua +++ b/src/lua/socket.lua @@ -995,7 +995,13 @@ local function getaddrinfo(host, port, timeout, opts) end end - return internal.getaddrinfo(host, port, timeout, ga_opts) + + local ret, err = internal.getaddrinfo(host, port, timeout, ga_opts) + if ret == nil then + boxerrno(boxerrno.EINVAL) + return nil, err + end + return ret end -- tcp connector @@ -1041,9 +1047,12 @@ local function tcp_connect(host, port, timeout) end local timeout = timeout or TIMEOUT_INFINITY local stop = fiber.clock() + timeout - local dns = getaddrinfo(host, port, timeout, { type = 'SOCK_STREAM', + local dns, err = getaddrinfo(host, port, timeout, { type = 'SOCK_STREAM', protocol = 'tcp' }) - if dns == nil or #dns == 0 then + if dns == nil then + return nil, err + end + if #dns == 0 then boxerrno(boxerrno.EINVAL) return nil end @@ -1360,8 +1369,12 @@ local function lsocket_tcp_connect(self, host, port) -- This function is broken by design local ga_opts = { family = 'AF_INET', type = 'SOCK_STREAM' } local timeout = deadline - fiber.clock() - local dns = getaddrinfo(host, port, timeout, ga_opts) - if dns == nil or #dns == 0 then + local dns, err = getaddrinfo(host, port, timeout, ga_opts) + if dns == nil then + self._errno = boxerrno() + return nil, err + end + if #dns == 0 then self._errno = boxerrno.EINVAL return nil, socket_error(self) end @@ -1547,9 +1560,12 @@ local function lsocket_connect(host, port) if host == nil or port == nil then error("Usage: luasocket.connect(host, port)") end - local s = tcp_connect(host, port) + local s, err = tcp_connect(host, port) if not s then - return nil, boxerrno.strerror() + if not err then + return nil, boxerrno.strerror() + end + return nil, err end setmetatable(s, lsocket_tcp_client_mt) return s diff --git a/test/app/socket.result b/test/app/socket.result index fd299424c..a9fe840be 100644 --- a/test/app/socket.result +++ b/test/app/socket.result @@ -941,10 +941,20 @@ sc:close() - true ... -- tcp_connect --- test timeout -socket.tcp_connect('127.0.0.1', 80, 0.00000000001) +-- Test timeout. In this test, tcp_connect can return the second +-- output value from internal.getaddrinfo (usually on Mac OS, but +-- theoretically it can happen on Linux too). Sometimes +-- getaddrinfo() is timed out, sometimes connect. On Linux however +-- getaddrinfo is fast enough to never give timeout error in +-- the case. So, there are two sources of timeout errors that are +-- reported differently. This difference has appeared after +-- gh-4138 patch. +s, err = socket.tcp_connect('127.0.0.1', 80, 0.00000000001) --- -- null +... +s == nil +--- +- true ... -- AF_INET s = socket('AF_INET', 'SOCK_STREAM', 'tcp') @@ -2816,6 +2826,48 @@ test_run:cmd("clear filter") --- - true ... +-- gh-4138 Check getaddrinfo() error from socket:connect() only. +-- Error code and error message returned by getaddrinfo() depends +-- on system's gai_strerror(). +test_run:cmd("setopt delimiter ';'") +--- +- true +... +function check_err(err) + if err == 'getaddrinfo: nodename nor servname provided, or not known' or + err == 'getaddrinfo: Servname not supported for ai_socktype' or + err == 'getaddrinfo: Name or service not known' then + return true + end + return false +end; +--- +... +test_run:cmd("setopt delimiter ''"); +--- +- true +... +s, err = socket.getaddrinfo('non_exists_hostname', 3301) +--- +... +check_err(err) +--- +- true +... +s, err = socket.connect('non_exists_hostname', 3301) +--- +... +check_err(err) +--- +- true +... +s, err = socket.tcp_connect('non_exists_hostname', 3301) +--- +... +check_err(err) +--- +- true +... -- case: sicket receive inconsistent behavior chan = fiber.channel() --- diff --git a/test/app/socket.test.lua b/test/app/socket.test.lua index c72d41763..7086e496b 100644 --- a/test/app/socket.test.lua +++ b/test/app/socket.test.lua @@ -300,8 +300,16 @@ sc:close() -- tcp_connect --- test timeout -socket.tcp_connect('127.0.0.1', 80, 0.00000000001) +-- Test timeout. In this test, tcp_connect can return the second +-- output value from internal.getaddrinfo (usually on Mac OS, but +-- theoretically it can happen on Linux too). Sometimes +-- getaddrinfo() is timed out, sometimes connect. On Linux however +-- getaddrinfo is fast enough to never give timeout error in +-- the case. So, there are two sources of timeout errors that are +-- reported differently. This difference has appeared after +-- gh-4138 patch. +s, err = socket.tcp_connect('127.0.0.1', 80, 0.00000000001) +s == nil -- AF_INET s = socket('AF_INET', 'SOCK_STREAM', 'tcp') @@ -960,6 +968,27 @@ server:close() test_run:cmd("clear filter") +-- gh-4138 Check getaddrinfo() error from socket:connect() only. +-- Error code and error message returned by getaddrinfo() depends +-- on system's gai_strerror(). +test_run:cmd("setopt delimiter ';'") +function check_err(err) + if err == 'getaddrinfo: nodename nor servname provided, or not known' or + err == 'getaddrinfo: Servname not supported for ai_socktype' or + err == 'getaddrinfo: Name or service not known' then + return true + end + return false +end; +test_run:cmd("setopt delimiter ''"); + +s, err = socket.getaddrinfo('non_exists_hostname', 3301) +check_err(err) +s, err = socket.connect('non_exists_hostname', 3301) +check_err(err) +s, err = socket.tcp_connect('non_exists_hostname', 3301) +check_err(err) + -- case: sicket receive inconsistent behavior chan = fiber.channel() counter = 0 diff --git a/test/box/net.box.result b/test/box/net.box.result index e3dabf7d9..0635ca9e7 100644 --- a/test/box/net.box.result +++ b/test/box/net.box.result @@ -3927,6 +3927,34 @@ test_run:grep_log('default', '00000040:.*') --- - null ... +-- gh-4138 Check getaddrinfo() error from connect() only. Error +-- code and error message returned by getaddrinfo() depends on +-- system's gai_strerror(). +test_run:cmd("setopt delimiter ';'") +--- +- true +... +function check_err(err) + if err == 'getaddrinfo: nodename nor servname provided, or not known' or + err == 'getaddrinfo: Servname not supported for ai_socktype' or + err == 'getaddrinfo: Name or service not known' then + return true + end + return false +end; +--- +... +test_run:cmd("setopt delimiter ''"); +--- +- true +... +s = remote.connect('non_exists_hostname:3301') +--- +... +check_err(s['error']) +--- +- true +... box.cfg{log_level=log_level} --- ... diff --git a/test/box/net.box.test.lua b/test/box/net.box.test.lua index 8e65ff470..9c9aee1ad 100644 --- a/test/box/net.box.test.lua +++ b/test/box/net.box.test.lua @@ -1582,4 +1582,21 @@ test_run:wait_log('default', '00000030:.*', nil, 10) -- we expect nothing below, so don't wait test_run:grep_log('default', '00000040:.*') +-- gh-4138 Check getaddrinfo() error from connect() only. Error +-- code and error message returned by getaddrinfo() depends on +-- system's gai_strerror(). +test_run:cmd("setopt delimiter ';'") +function check_err(err) + if err == 'getaddrinfo: nodename nor servname provided, or not known' or + err == 'getaddrinfo: Servname not supported for ai_socktype' or + err == 'getaddrinfo: Name or service not known' then + return true + end + return false +end; +test_run:cmd("setopt delimiter ''"); + +s = remote.connect('non_exists_hostname:3301') +check_err(s['error']) + box.cfg{log_level=log_level}
next prev parent reply other threads:[~2019-12-10 16:25 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-15 16:58 [tarantool-patches] [PATCH] " Roman Khabibov 2019-06-23 20:31 ` [tarantool-patches] " Alexander Turenko 2019-06-25 13:38 ` [tarantool-patches] Re: [PATCH v2 1/2] " Roman Khabibov 2019-07-09 8:04 ` Alexander Turenko 2019-07-10 2:16 ` Roman Khabibov 2019-07-23 12:39 ` Alexander Turenko 2019-07-26 13:48 ` Alexander Turenko 2019-08-05 13:36 ` Roman Khabibov 2019-08-29 0:45 ` Alexander Turenko [not found] ` <868EAF2C-A491-46C9-AD37-7512D6CAB213@tarantool.org> 2019-09-06 13:45 ` [tarantool-patches] Re: [server-dev] " Alexander Turenko 2019-09-10 12:54 ` Roman Khabibov 2019-11-01 14:39 ` [Tarantool-patches] [server-dev] Re: [tarantool-patches] " Alexander Turenko 2019-11-21 17:27 ` [Tarantool-patches] [tarantool-patches] [server-dev] " Roman Khabibov 2019-12-08 19:48 ` Alexander Turenko 2019-12-10 16:25 ` Roman Khabibov [this message] 2019-12-18 14:58 ` Alexander Turenko 2019-12-21 17:50 ` Roman Khabibov 2019-12-23 13:36 ` Alexander Turenko 2019-12-26 17:29 ` Roman Khabibov 2020-02-18 13:55 ` [Tarantool-patches] Fwd: " Roman Khabibov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=35E941DB-8252-478B-80C2-592FFAA6011E@tarantool.org \ --to=roman.habibov@tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [tarantool-patches] [server-dev] Re: Re: [PATCH v2 1/2] lua: return getaddrinfo() errors' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox